search

mozilla / active-data-recipes

A repository of various activedata queries and recipes
Mozilla Public License 2.0
8 stars 24 forks source link

Show single subtest across all perf suites #114

Closed klahnakoski closed 5 years ago

klahnakoski commented 5 years ago

image

klahnakoski commented 5 years ago

I assume you will merge this if it is good.

davehunt commented 5 years ago

This looks excellent, thanks @klahnakoski! One comment on the output is that we're planning to remove the redundancy of the test name from the subtest name in bug 1520417. This change will make the output less clear, so I'm wondering if we can output the test name for each row and the shortened subtest name in the column header?

klahnakoski commented 5 years ago

@davehunt I will fix the test/suite names, like you suggest, when they change.

klahnakoski commented 5 years ago

@ahal sorry I missed the automated checks. ready for another review

klahnakoski commented 5 years ago

image

ahal commented 5 years ago

Turns out deleting that list exposes a bug, my apologies! I'll see if I can fix it myself before merging.

ahal commented 5 years ago

Ok this will be fixed in PR 117. I'll merge this after that other one lands.