search

mozilla / active-data-recipes

A repository of various activedata queries and recipes
Mozilla Public License 2.0
9 stars 24 forks source link

show number of activedata requests by day #21

Closed klahnakoski closed 6 years ago

klahnakoski commented 6 years ago

This is a good example where a query can be run on it's own

ahal commented 6 years ago

Thanks, this looks good but I recently added a doclint linter that will fail travis if there is documentation missing.

Can you please add this to docs/recipes.rst as well as add a module-level docstring to the recipe file? You can take a look at other recipes to see an example. You'll need to rebase your changes on top of the latest master.

klahnakoski commented 6 years ago

I am not sure about the documentation magic, but I copied other recipes hoping it works.

ahal commented 6 years ago

Yeah, that should work. Fyi to run all the tests and linter's locally you can just run: tox (you may need to pip install it first)