Refactor ADR command line runner for recipe and query - Githubissues

mozilla / active-data-recipes

A repository of various activedata queries and recipes

Mozilla Public License 2.0

9 stars 24 forks source link

Refactor ADR command line runner for recipe and query #29

Closed worldomonation closed 6 years ago

worldomonation commented 6 years ago

A moderately extensive refactor of the recipe and query runner.

Major changes:

recipe runner is split out of cli.py.
query runner has number of operations reduced.
cli.py repurposed to only handle command line interaction with user.

Under the hood changes:

most operations have been split into helper commands.
log import logic is changed to reference logger instance by name.
use of subparser to separate code paths.
documentation for nearly all methods.

Additional upstream changes merged:

url parameter argument work by @nadaa merged into this PR and adjusted to work with structural changes introduced in this patch.

worldomonation commented 6 years ago

Also, this merge should not have conflict with base branch, finally :)