search

mozilla / active-data-recipes

A repository of various activedata queries and recipes
Mozilla Public License 2.0
9 stars 24 forks source link

Add a flask app for adr #38

Closed nadaa closed 6 years ago

nadaa commented 6 years ago

Issue #34 A flask app for active data recipes to help users navigate and execute the recipes.

ahal commented 6 years ago

Thanks, I'll take a look now. Though just fyi I'd recommend using separate branches for your different patches. That way your changes are independent from one another, and your flask changes won't need to depend on your test_formatter ones. Here is a good guide from github: https://guides.github.com/introduction/flow/

ahal commented 6 years ago

Also you'll want to pull in the latest master branch and rebase this PR, I changed the tox.ini so that all directories will be linted by flake8 (you'll notice a few flake8 issues in this PR now).

klahnakoski commented 6 years ago

I suggest ADR be limited to providing a restful endpoint. The frontend should be written in React, and made to use this endpoint. Having minimal html output from ADR is good for proving this PR, but I hope not much more effort goes into writing a frontend in Python.

nadaa commented 6 years ago

Hi @klahnakoski, I agree with you, React wins for the frontend. Making simple templates using flask was fine, but I am not sure it will be easy when the app grows.

ahal commented 6 years ago

Hi @nadaa, did you manage to figure out your git issues? I remember seeing an e-mail about it but don't see it anymore. Sorry I've been a bit slow this week, I've been out for most of it.