search

mozilla / active-data-recipes

A repository of various activedata queries and recipes
Mozilla Public License 2.0
9 stars 24 forks source link

`adr task_durations --branch <branch>` doesn't work #45

Closed ahal closed 6 years ago

ahal commented 6 years ago

Add a print(query_args) statement here: https://github.com/mozilla/active-data-recipes/blob/master/adr/recipes/task_durations.py#L34

Then run adr task_durations --branch mozilla-inbound. Notice that the 'branch' value is still the default set instead of just ['mozilla-inbound'].

kerlynNkep commented 6 years ago

Hi @ahal, am here and will look into this right away.

ahal commented 6 years ago

Thanks! Let me know if you have any questions.

kerlynNkep commented 6 years ago

Hi @ahal, I have something working out like this

issue45

I also wish to verify if the branches listed in DEFAULT_BRANCHES are all the branches that exist at the moment.

ahal commented 6 years ago

Looks great, thanks! Feel free to put up a PR and I'll take a look. There are more branches outside of DEFAULT_BRANCHES, but you shouldn't need to worry about that here.

kerlynNkep commented 6 years ago

@ahal okay sending a PR straight away.

kerlynNkep commented 6 years ago

Hi @ahal i have sent a PR. Please can you check and get back to me. And also please would want you to assign me to another task while you are reviewing this.

ahal commented 6 years ago

Thanks for the fix @kerlynNkep! Looks like all the issues got taken in the meantime, but I'll try to file some more today or tomorrow. I'll mention you in it when I do.