mozilla / active-data-recipes

A repository of various activedata queries and recipes

Mozilla Public License 2.0

8 stars 24 forks source link

Added a unittest for query.py #46

Closed nikk15 closed 5 years ago

nikk15 commented 5 years ago

28 @ahal My additions so far.

Added test_queries.py, following a similar structure to the recipe tests.
Edited conftest.py to also include ability to read .test files from the newly created query_tests folder.
For now I have only been testing against the data total_files query returns, as that query is known to work.

I haven't been able to successfully run the test yet as I struck an error. If someone could please take a look at my notes in the test_queries.py file, I would love some feedback. Am I on the right track?

Thank you!

nikk15 commented 5 years ago

Hi @ahal!

test_queries.py should hopefully be good to go in its most basic form for now, pending checks. Although, is there a better way to test mocked data? Right now, in my .test files, I am basically asserting if the mock_data == expected.

I also wasn't sure if lines 40 & 41 in test_queries.py were necessary? I followed the format for the recipe tests, which include them, but am not sure what these do in this circumstance.

Cheers!

nikk15 commented 5 years ago

Thanks @ahal! I would love to get this landed first and then continue working on the next additions. Cheers.

ahal commented 5 years ago

Looks good! There are a few conflicts with master but I'll see if I can resolve them in github.

ahal commented 5 years ago

Thanks very much!