search

mozilla / active-data-recipes

A repository of various activedata queries and recipes
Mozilla Public License 2.0
9 stars 24 forks source link

Create a landing page + recipe specific pages for the web app #49

Open ahal opened 6 years ago

ahal commented 6 years ago

Currently all the recipes are linked from a single page, and clicking them populates the right side with data. Since we want to provide recipe specific options, I think it would be nice if every recipe had their own page.

So the main "landing" page would still have links to every recipe, but clicking the link would then bring you to a recipe specific page. In this recipe specific page, we would have the "Run" button and the place to display output. We could also display the recipe name and docstring near the top.

ahal commented 6 years ago

Hey @nadaa, if you were interested in continuing on the web app, this might be a good next one to pick up!

nadaa commented 6 years ago

Sure @ahal, count me in!. One question about the platform, do we need to continue using flask templates, or shall we move to React?- @klahnakoski suggested this!

ahal commented 6 years ago

Oops, missed your question @nadaa . React is a front-end library, so whether we use it or not is actually entirely independent from our decision to use flask. I kind of think that using React is not worth it for this small use-case, but that's only because I'm not familiar with webdev and it scares me :).

But to answer your question, yes we should continue to use flask on the backend. It is a nice and simple library that is easy to integrate in Python.

P.S I was planning to deprecate python 2 in adr, so if you aren't already, please make sure you are developing with python 3. Thanks!

nadaa commented 6 years ago

Hi @ahal, thanks for comment!. Yes, maybe for this task I 'll continue using flask templates, and web dev is nice :). I think React might help if the front-end application becomes large. Thanks for the python update, I hadn't had time to work on this issue, but hopefully the coming days.

rabyatouyimga commented 6 years ago

@ahal could I join in on this?

nadaa commented 6 years ago

hi @ahal, I created a new template to display a recipe, we can put parameters and run the recipe. we need now to add info for each recipe, I think to add a function in each recipe.py which returns its details, what do you think? and maybe we can do the same for parameters?

nadaa commented 6 years ago

I think I will hardcode the info & arguments for each recipe for now, and I will think out how to restructure the recipes as you mentioned here #40

MadinaB commented 6 years ago

Have fixed this issue with pr #65