search

mozilla / active-data-recipes

A repository of various activedata queries and recipes
Mozilla Public License 2.0
9 stars 24 forks source link

Running `adr <recipe> -- --help` no longer displays recipe help #55

Closed ahal closed 6 years ago

ahal commented 6 years ago

This is a regression from a cli refactoring. I'm not exactly sure what's happening, but I think it's because we dynamically add the subparsers in based on the arguments: https://github.com/mozilla/active-data-recipes/blob/master/adr/cli.py#L173

I believe fixing this issue will involve making it so the subparsers are always added regardless of whether or not 'recipe' or 'query' show up in the args.

We should try to preserve the current behaviour however where we can run all of:

  1. adr <recipe>
  2. adr recipe <recipe>
  3. adr query <query>
kerlynNkep commented 6 years ago

Hi @ahal. Ill get on this.

kerlynNkep commented 6 years ago

Hi @ahal, please i wish to find out from you which among these frameworks [Angular, Flask and React] will be used in designing the dashboard for this project.

ahal commented 6 years ago

Hi @kerlynNkep, this specific issue isn't related to the web dashboard, so doesn't require any frameworks to complete. It requires python only in the cli.py file. If you wish to do some webdev, you can try your hand at issue #48. Just be aware that some other applicants may also be working on it, so there's a chance I won't be able to merge your work if you do.

This issue will require some in-depth knowledge of python's argparse module.

kerlynNkep commented 6 years ago

@ahal Yes i know that this issue is not related to web dashboard. The question was relating to the internship project. Am sorry for posting the question here knowing it is not related to the issue.

MadinaB commented 6 years ago

Hello!

I think this fix (--help display fix #63) deals with the bug, could you please check that?