search

mozilla / active-data-recipes

A repository of various activedata queries and recipes
Mozilla Public License 2.0
8 stars 24 forks source link

--help display fix #63

Closed MadinaB closed 5 years ago

MadinaB commented 5 years ago

Resolving bug in issue #55

MadinaB commented 5 years ago

Hello @ahal , I have tried to solve it and it works for adr <recipe > --help. Thus, it treats --help now as an optional argument and conflicts with 'adr --help' were avoided by adding 'conflict_handler='resolve'' on parser creations.

ahal commented 5 years ago

Hello @ahal , I have tried to solve it and it works for adr <recipe > --help. Thus, it treats --help now as an optional argument and conflicts with 'adr --help' were avoided by adding 'conflict_handler='resolve'' on parser creations.

Thanks, I think you forgot to re-push your changes though!

MadinaB commented 5 years ago

It is a bit different since it uses not "-- -- help", but "--help", so I pushed with new PR since was not sure whether u will like this behavior. It is here: https://github.com/mozilla/active-data-recipes/pull/73

ahal commented 5 years ago

Oh, thanks! Let's close out this PR then.