mozilla / activity-stream

A refreshed "new tab page" for Firefox
Mozilla Public License 2.0
183 stars 113 forks source link

Pocket Card changes: date, saves #2620

Closed tspurway closed 7 years ago

tspurway commented 7 years ago

Let's add the link date, the number of saves and add the Pocket chevron button to save to your pocket account.

pocket card
pdehaan commented 7 years ago

Friendly reminder, I think in the past w/ Pocket, we'd see some items without a date. I was trying to browse the returned data from https://getpocket.com/v3/firefox/global-recs?consumer_key=xyz and I only saw one suspicious looking result:

{
  id: 569,
  url: "https://pocket.co/sMTKmt",
  dedupe_url: "http://www.nytimes.com/2017/05/19/business/washington-post-digital-news.html",
  title: "Cookies are Not Accepted",
  excerpt: "We're sorry, we are not able to log you in Terms of Service | Privacy Policy",
  domain: "nytimes.com",
  image_src: false,
  published_timestamp: "0",
  sort_id: 11
},

So we may want to try checking for non-zero published_timestamp values before converting them to timestamps and displaying them.

pdehaan commented 7 years ago

Took a bit of scrolling, but managed to find one example on https://getpocket.com/explore/technology?src=ff_new_tab where the entry doesn't have a displayed date:

top_articles_and_videos_about_tech_on_pocket
aaronrbenson commented 7 years ago

Working on a couple more revisions here based on our meeting with Pocket this morning. We discussed running the date label as an experiment, and need the "Trending" label needs to come back. Adding the "Save to Pocket" button is a nice-to-have based on the amount of work needed.

mariappopova commented 7 years ago

@emtwo @ncloudioj We want to launch an experiment with the date in the pocket story card.

aaronrbenson commented 7 years ago

Updated comp here: https://mozilla.invisionapp.com/share/2XC0HP3GR#/237227360_Photon

csadilek commented 7 years ago

@aaronrbenson Hi, there seems to be a new feature in the tiles to differentiate between "New" and "Trending". Can you share some background on this? We're wondering how we'd know what's "New"? Thanks.

aaronrbenson commented 7 years ago

@csadilek Yeah, the "new" context label would show trending items that are dated within the last 24 hours. This might help to clue people into more "breaking" stories vs. trending topics.

csadilek commented 7 years ago

Based on the discussion on Monday, the only planned task is adding the differentiation between "new" (< 24hrs) and "trending" tiles. Given we can get the "new" icon from @aaronrbenson, I think we can schedule this for the next release (Bridge of the River Kwai).

Note that some tiles don't have a publication date set when retrieved from Pocket's backend. Therefore these tiles will show up as "trending" and never as "new".

csadilek commented 7 years ago

If this feature is still desired and when the icon is ready the functionality is ready in this branch: https://github.com/csadilek/activity-stream/tree/2620

aaronrbenson commented 7 years ago

We're not doing this in the foreseeable future. Closing.