Bug 1589025 - Displaying privacy modal in correct position

mozilla / activity-stream

A refreshed "new tab page" for Firefox

Mozilla Public License 2.0

183 stars 113 forks source link

Bug 1589025 - Displaying privacy modal in correct position #5362

Closed gvn closed 5 years ago

gvn commented 5 years ago

@k88hudson As far as I can tell & observe this isn't causing any regressions, but since the modal is used by trailhead I figured you might be able to give a 2nd opinion there. Positioning is fixed by default and this was overriding to absolute – unsure why. 🤔

Test steps: https://bugzilla.mozilla.org/show_bug.cgi?id=1589025#c0

Mardak commented 5 years ago

Without the position: absolute, users can't scroll down to "Start Browsing"

gvn commented 5 years ago

Without the position: absolute, users can't scroll down to "Start Browsing"

Ok, making the selector more specific then so it doesn't target every modal on about:welcome.