search

mozilla / activity-stream

A refreshed "new tab page" for Firefox
Mozilla Public License 2.0
183 stars 113 forks source link

(nobug) - Add browser and version attribution to ASRouter admin #5372

Closed piatra closed 4 years ago

piatra commented 4 years ago

Created a new branch chrome-switchers. We should work/merge work in this branch until https://bugzilla.mozilla.org/show_bug.cgi?id=1406005 merges and we have the final version of the data.

Requires an additional change in m-c to AttributionCode.jsm to know about these 2 new fields. 

diff --git a/browser/components/attribution/AttributionCode.jsm b/browser/components/attribution/AttributionCode.jsm
index 127827cc18b27..dda8f43ea3f74 100644
--- a/browser/components/attribution/AttributionCode.jsm
+++ b/browser/components/attribution/AttributionCode.jsm
@@ -32,6 +32,8 @@ const ATTR_CODE_KEYS = [
   "content",
   "experiment",
   "variation",
+  "browser",
+  "browser_version",
 ];

 let gCachedAttrData = null;

This should add browser and version in asrouter admin about:newtab#devtools-targeting -> Attribution Parameters section. This will allow us to do targeting based on these values and we can simulate the onboarding triplets.

Mardak commented 4 years ago

Moved to https://phabricator.services.mozilla.com/D57906