Bug 1574297 - "How it works" -> "What's Pocket?"

mozilla / activity-stream

A refreshed "new tab page" for Firefox

Mozilla Public License 2.0

183 stars 113 forks source link

Closed gvn closed 5 years ago

gvn commented 5 years ago

Test Steps:

gvn commented 5 years ago

@ScottDowne This will probably have some overlap with the DE work. ~~Do you think I should wait until that lands to merge this?~~

gvn commented 5 years ago

@flodolo Is there anything I need to do to get this string translated, or is landing it sufficient to trigger the process? Thanks!

flodolo commented 5 years ago

This needs to be ported to mozilla-central. Once it lands there, localization will start.

Mardak commented 5 years ago

@gvn did you get review from scott out of github? I would think flod only reviewed/approved the .ftl changes

gvn commented 5 years ago

@Mardak Yes.

ScottDowne commented 5 years ago

Yeah this looked good on my end. I've already rebased my DE patch against it and everything's working as intended.