search

mozilla / activity-stream

A refreshed "new tab page" for Firefox
Mozilla Public License 2.0
183 stars 113 forks source link

Bug 1598876 - Fix intermittent link test failure #5390

Open gvn opened 5 years ago

gvn commented 5 years ago

Run mach test discovery_render and confirm exit code of 0. (Try this several times.)

ScottDowne commented 5 years ago

I also wonder if we can instead of waiting and checking the text, just check for the href, and not the text content, thus it wouldn't need to be waiting for fluent. (we're not testing fluent anyway)

thoughts?

ScottDowne commented 5 years ago

Was thinking about this more. I think maybe ideally we have a test layout for this, so we don't have fluent strings being used here at all. (assuming that's the issue, which I'm only about 80% sure of)