mozilla / addon-compatibility-reporter

Add-on Compatibility Reporter (Redux)
https://wiki.mozilla.org/AMO:Projects/ACR
17 stars 12 forks source link

Notifications #74

Closed TonyDthe3rd closed 7 years ago

TonyDthe3rd commented 7 years ago

Hello, attached is a screen shot of the add-on at work. It doesn't show any of the buttons or notices about compatibility or reporting. It did for a minute initially. I disabled all the incompatible add-ons a restarted. The screen shot is what it shows now. Is this correct? Is there a conflict that suppresses the functionality of ACR? Thanks for your thought.

Tony

acr view on extension page

wagnerand commented 7 years ago

Thank you for your report.

What version of Firefox and Add-on Compatibility Reporter are you using?

How familiar are you with Firefox? Can you check the error console to see if there's anything that could give us a hint what exactly breaks?

TonyDthe3rd commented 7 years ago

Hello Mr. Wagner:

50.02 and the most recent installation.

I think the problem is a Mozilla multi-process problem rather than your extension. Going to “about: support” I noticed the multiprocess disabled by accessibility tools message was showing. This is on my networked pc at work so I have limited control of the image. I am actually not having the problem on my home machine. On the work machine I had refreshed the browser, installed a few add-ons including ACR and it worked perfectly. I disabled the add-ons that showed incompatible. Some required a restart. When the browser restarted, this kicked off multi-process due to accessibility tools as I learned is the MZ policy. This also seems to interfere with your add on too. Do you have any idea which “tools” typically cause this problem? I could not identify the culprits.

Thanks.

Tony D’Acci

From: Andreas Wagner [mailto:notifications@github.com] Sent: Tuesday, December 06, 2016 4:38 PM To: mozilla/addon-compatibility-reporter addon-compatibility-reporter@noreply.github.com Cc: TonyDthe3rd ajdacci3@gmail.com; Author author@noreply.github.com Subject: Re: [mozilla/addon-compatibility-reporter] Notifications (#74)

Thank you for your report.

What version of Firefox and Add-on Compatibility Reporter are you using?

How familiar are you with Firefox? Can you check the error console to see if there's anything that could give us a hint what exactly breaks?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/mozilla/addon-compatibility-reporter/issues/74#issuecomment-265319521 , or mute the thread https://github.com/notifications/unsubscribe-auth/AXSgs-7FlZwQY29glhj3rdo4IcJCDaU0ks5rFf_TgaJpZM4LF7jR .

wagnerand commented 7 years ago

No, the problem looks like something related to ACR.

The extension needs to work with and without multi process Firefox. The fact that multi process was disabled is due to another add-on you installed that does not support multi process.

I'm afraid without some instructions how to reproduce the issue or a precise error message, I'm not sure what to do about this.

Could you please check the error console in Firefox to see if there are any errors shown related to the add-on?

geekyi commented 7 years ago

Same problem. ACR Version 2.2.3

From error console, with all my addons:

17:56:31.440 SDK worker-child started as frozen on unexpected initial document.readyState Object { initialDocumentReadyState: "uninitialized", windowLocation: "about:addons" } 1 worker-child.js:62

about:support

Application Basics
------------------

Name: Firefox
Version: 51.0b6
Build ID: 20161201172143
Update Channel: beta
User Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:51.0) Gecko/20100101 Firefox/51.0
OS: Windows_NT 10.0
Multiprocess Windows: 0/1 (Disabled)
Safe Mode: false

Will check later with a clean profile, other addons disabled, etc

TonyDthe3rd commented 7 years ago

Mr. Wagner:

I afraid I’ll be away from my work computer until Monday. I’ll check the console then. I am using two profiles now. One from a refresh where you ARC works with a number of add-ons, found on “Are We e10 Yet” no others. The other profile doesn’t with, incld ARC, 3 compatible enabled but multiprocess disabled do to some accessibility tool problem. Safe mode doesn’t change the disabled multiprocess status. We are on Windows 7 there. I grab the console report Monday.

Tony

From: Andreas Wagner [mailto:notifications@github.com] Sent: Thursday, December 08, 2016 11:32 AM To: mozilla/addon-compatibility-reporter addon-compatibility-reporter@noreply.github.com Cc: TonyDthe3rd ajdacci3@gmail.com; Author author@noreply.github.com Subject: Re: [mozilla/addon-compatibility-reporter] Notifications (#74)

No, the problem looks like something related to ACR.

The extension needs to work with and without multi process Firefox. The fact that multi process was disabled is due to another add-on you installed that does not support multi process.

I'm afraid without some instructions how to reproduce the issue or a precise error message, I'm not sure what to do about this.

Could you please check the error console in Firefox to see if there are any errors shown related to the add-on?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/mozilla/addon-compatibility-reporter/issues/74#issuecomment-265832401 , or mute the thread https://github.com/notifications/unsubscribe-auth/AXSgs0oOXlQMxuOl3vBEwy5zDizPp9NYks5rGFs_gaJpZM4LF7jR .

geekyi commented 7 years ago

So I tried this out in a clean profile and it works! Actually, this may be related to multiprocess. I did find some weird bugs which I wasn't able to reproduce. Not sure if it is caused by the browser or ACR addon. My profile info from about:support. I had these tabs open: about:addons, about:support (check e10s enabled), about:config I tried out some tests: (actually fiddled around)

Reproducible Tests

Test enable/disable ACR

  1. go to about:addons and disable ACR

    Result 1

    Error in console:

    WARN    AddonListener threw exception when calling onDisabling: TypeError: can't access dead object (resource://gre/modules/AddonManager.jsm:1756:1) JS Stack trace: AddonManagerInternal.callAddonListeners@AddonManager.jsm:1756:1 < this.AddonManagerPrivate.callAddonListeners@AddonManager.jsm:3075:5 < this.XPIProvider.updateAddonDisabledState@XPIProvider.jsm:5056:9 < set userDisabled@XPIProvider.jsm:7608:9 < set_userDisabled@extensions.xml:1084:11 < oncommand@about:addons:1:1

    Result 2

    Similar error on enabling:

    addons.manager  WARN    AddonListener threw exception when calling onEnabled: TypeError: can't access dead object (resource://gre/modules/AddonManager.jsm:1756:1) JS Stack trace: AddonManagerInternal.callAddonListeners@AddonManager.jsm:1756:1 < this.AddonManagerPrivate.callAddonListeners@AddonManager.jsm:3075:5 < this.XPIProvider.updateAddonDisabledState@XPIProvider.jsm:5081:11 < set userDisabled@XPIProvider.jsm:7608:9 < set_userDisabled@extensions.xml:1084:11 < oncommand@about:addons:1:1

    Conclusion

    I think this is caused by ACR modifying the addons UI?

Heinsenbug (non-reproducible)

May or may not be caused by the addon or browser. Also, I have an incompatible 3rd party addon which is disabled by default by firefox, so I don't think it would have an effect. But just fyi

Test enable/disable multiprocess

  1. go to about:config and search for browser.tabs.re
  2. toggle browser.tabs.remote.autostart.2 (initially enabled by firefox)
  3. open devtoolbar shift+f2 and enter command restart

    Result

    when navigating to about:addons the results from 'get addons' and 'extensions' tab are mixed. Probably when e10s is disabled. No errors in browser console

    Test enable/disable ACR 2

  4. open devtoolbar shift+f2
  5. enable ACR addon

    Result

    Dev toolbar disappears. Cannot enable or disable it. No errors in browser console

    Verdict

    Hard to say what was wrong. So far, it mostly works on the new profile. Could be any number of factors at play on my old firefox user: old profile, multiprocess, addons, UI modifications

geekyi commented 7 years ago

Ok. So it turns out my issue was the same as #69 which is a bit illogical imho. In my case I have enabled "Always use private browsing mode" Having it disabled for private browsing is counter-intuitive, as it is supposed to only collect data on addons. Afaik, the list of addons doesn't change whether you have enabled private browsing or not? This info that it gets disabled should be more prominent (notification on install or at least as a FAQ), but ideally, I'd want this to work even in private browsing mode. Thank you for your time

TonyDthe3rd commented 7 years ago

Thanks for the update

From: geekyi [mailto:notifications@github.com] Sent: Wednesday, December 14, 2016 8:33 AM To: mozilla/addon-compatibility-reporter addon-compatibility-reporter@noreply.github.com Cc: TonyDthe3rd ajdacci3@gmail.com; Author author@noreply.github.com Subject: Re: [mozilla/addon-compatibility-reporter] Notifications (#74)

Ok. So it turns out my issue was the same as #69 https://github.com/mozilla/addon-compatibility-reporter/issues/69 which is a bit illogical imho. In my case I have enabled "Always use private browsing mode" Having it disabled for private browsing is counter-intuitive, as it is supposed to only collect data on addons. Afaik, the list of addons doesn't change whether you have enabled private browsing or not? This info that it gets disabled should be more prominent (notification on install or at least as a FAQ), but ideally, I'd want this to work even in private browsing mode. Thank you for your time

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/mozilla/addon-compatibility-reporter/issues/74#issuecomment-267082423 , or mute the thread https://github.com/notifications/unsubscribe-auth/AXSgs1Eeo5XRdpQvxyVsFA2Nhkp3IxXzks5rIBpIgaJpZM4LF7jR .

wagnerand commented 7 years ago

@TonyDthe3rd the initial screenshot you showed does not indicate the window is a private-browsing window. Can you confirm that the issue you are seeing happens only in private-browsing?

geekyi commented 7 years ago

He may also be like me, in "Always use private browsing mode". There is no indication in the ui in that case. @TonyDthe3rd should still confirm. (Well. Right-click context menu on link only shows "open link in new private window")

I still consider this a bug tho. Anything I can do to help?

wagnerand commented 7 years ago

This issue is getting a bit confusing. I'd like to limit the scope to the initial report where the add-ons manager does not show the ACR buttons. If you experience another issue, please submit it as a new one.

TonyDthe3rd commented 7 years ago

I wasn’t on private browsing. Something Else I hadn’t thought about, Our IT contractors have a remote program on our system that causes multiprocessing in Firefox to disable.

From: Andreas Wagner [mailto:notifications@github.com] Sent: Wednesday, December 21, 2016 5:36 AM To: mozilla/addon-compatibility-reporter addon-compatibility-reporter@noreply.github.com Cc: TonyDthe3rd ajdacci3@gmail.com; Mention mention@noreply.github.com Subject: Re: [mozilla/addon-compatibility-reporter] Notifications (#74)

@TonyDthe3rd https://github.com/TonyDthe3rd the initial screenshot you showed does not indicate the window is a private-browsing window. Can you confirm that the issue you are seeing happens only in private-browsing?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/mozilla/addon-compatibility-reporter/issues/74#issuecomment-268524057 , or mute the thread https://github.com/notifications/unsubscribe-auth/AXSgs8ycX-HEH59v0tUC6jbcCMElAT7qks5rKSsjgaJpZM4LF7jR .

wagnerand commented 7 years ago

Thanks for the info.

I'm not really sure what to do without knowing how to reproduce the issue or the exact error message.

geekyi commented 7 years ago

@TonyDthe3rd, just for completeness sake, can you also confirm about:preferences shows this: 2016-12-22 04_12_54-options

Or post a screenshot showing your privacy preferences? (Is there another way private browsing can be discreetly enabled?) It works for me with multiprocess enabled and disabled on windows

TonyDthe3rd commented 7 years ago

privacy settings no buttons ​Hello Geekyi and Andreas:

Find attached a screen of the privacy setting for the profile not showing the ACR buttons and Firefox text from their troubleshoot link under Help from both profiles, one with ACR buttons showing in Extensions​, and one without.

From: geekyi [mailto:notifications@github.com] Sent: Wednesday, December 21, 2016 3:24 PM To: mozilla/addon-compatibility-reporter <addon-compatibility-reporter@ noreply.github.com> Cc: TonyDthe3rd ajdacci3@gmail.com; Mention mention@noreply.github.com Subject: Re: [mozilla/addon-compatibility-reporter] Notifications (#74)

@TonyDthe3rd https://github.com/TonyDthe3rd, just for completeness sake, can you also confirm about:preferences shows this: [image: Image removed by sender. 2016-12-22 04_12_54-options] https://cloud.githubusercontent.com/assets/16749930/21409713/8897d430-c7fd-11e6-9f27-119bdee8476b.png

Or post a screenshot showing your privacy preferences? (Is there another way private browsing can be discreetly enabled?) It works for me with multiprocess enabled and disabled on windows

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/mozilla/addon-compatibility-reporter/issues/74#issuecomment-268671408, or mute the thread https://github.com/notifications/unsubscribe-auth/AXSgs7NS1g1euczWU3BtgawFdaSSKz03ks5rKbUlgaJpZM4LF7jR .[image: Image removed by sender.]

TonyDthe3rd commented 7 years ago

From Troubleshoot Info under Help in Menu Bar. I have two profiles one shows the ACR buttons and One doesn't

On Wed, Dec 21, 2016 at 12:46 PM, Andreas Wagner notifications@github.com wrote:

Thanks for the info.

I'm not really sure what to do without knowing how to reproduce the issue or the exact error message.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/mozilla/addon-compatibility-reporter/issues/74#issuecomment-268634995, or mute the thread https://github.com/notifications/unsubscribe-auth/AXSgs3dYFHnPbcRnhU3DMMNsF1lTh1g1ks5rKZAmgaJpZM4LF7jR .

-- Best Always,

Tony D'Acci

wagnerand commented 7 years ago

GitHub does not support email attachments, you can upload them on the website.

TonyDthe3rd commented 7 years ago

I believe it is actually set up to always be private, at least by never remembering history. I haven’t made any custom changes in regards to private browsing.

I actually have two profiles in Firefox, one shows no buttons and there other does. I can send screens of the troubleshoot pages. I can get to the web console and the developer tools, but I am not sure what report you would find helpful. I have no real experience in this area.

Tony

From: Andreas Wagner [mailto:notifications@github.com] Sent: Wednesday, December 21, 2016 10:17 AM To: mozilla/addon-compatibility-reporter addon-compatibility-reporter@noreply.github.com Cc: TonyDthe3rd ajdacci3@gmail.com; Mention mention@noreply.github.com Subject: Re: [mozilla/addon-compatibility-reporter] Notifications (#74)

This issue is getting a bit confusing. I'd like to limit the scope to the initial report where the add-ons manager does not show the ACR buttons. If you experience another issue, please submit it as a new one.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/mozilla/addon-compatibility-reporter/issues/74#issuecomment-268599195 , or mute the thread https://github.com/notifications/unsubscribe-auth/AXSgs7LSUxNEl652FPga7ECIs3dO3mJJks5rKW0xgaJpZM4LF7jR .

TonyDthe3rd commented 7 years ago

I think that’s actually the case.

From: geekyi [mailto:notifications@github.com] Sent: Wednesday, December 21, 2016 8:32 AM To: mozilla/addon-compatibility-reporter addon-compatibility-reporter@noreply.github.com Cc: TonyDthe3rd ajdacci3@gmail.com; Mention mention@noreply.github.com Subject: Re: [mozilla/addon-compatibility-reporter] Notifications (#74)

He may also be like me, in "Always use private browsing mode". There is no indication in the ui in that case. @TonyDthe3rd https://github.com/TonyDthe3rd should still confirm. (Well. Right-click context menu on link only shows "open link in new private window")

I still consider this a bug tho. Anything I can do to help?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/mozilla/addon-compatibility-reporter/issues/74#issuecomment-268568016 , or mute the thread https://github.com/notifications/unsubscribe-auth/AXSgs9vgt4gg_vR8bPlr_S-PN92_dPcDks5rKVSAgaJpZM4LF7jR .

TonyDthe3rd commented 7 years ago

Buttons not showing Application Basics.pdf Buttons showing Application Basics.pdf

privacy settings no buttons

TonyDthe3rd commented 7 years ago

Attachment referred to earlier posted above