search

mozilla / addon-compatibility-reporter

Add-on Compatibility Reporter (Redux)
https://wiki.mozilla.org/AMO:Projects/ACR
17 stars 12 forks source link

All extensions say "compatible" but about:support says e10s "disabled by add-ons" #76

Closed ian-kelling closed 7 years ago

ian-kelling commented 7 years ago

Firefox 51.0.1-1 (debian).

I have 3 plugins which came out of the box, no compatibility message is shown for them.

I set browser.tabs.remote.autostart to true.

e10s seems to work fine setting the force option to true.

wagnerand commented 7 years ago

Thank you for your report.

Can you please go to about:support and send us a support profile? If you prefer, you can also send it to me privately, by emailing awagner AT mozilla DOT com.

ian-kelling commented 7 years ago

More info: I ran a fresh profile. Enabled e10s, it works. Installed this extension, I get "disabled by addons." Disabled the addon, e10s enabled again. Seems to be the same for any extension.

ian-kelling commented 7 years ago 
{
  "application": {
    "name": "Firefox",
    "osVersion": "Linux 4.9.0-1-amd64",
    "version": "51.0.1",
    "buildID": "20170205065236",
    "userAgent": "Mozilla/5.0 (X11; Linux x86_64; rv:51.0) Gecko/20100101 Firefox/51.0",
    "safeMode": false,
    "supportURL": "https://support.mozilla.org/1/firefox/51.0.1/Linux/en-US/",
    "numTotalWindows": 1,
    "numRemoteWindows": 0,
    "remoteAutoStart": false,
    "autoStartStatus": 7
  },
  "modifiedPreferences": {
    "browser.cache.frecency_experiment": 3,
    "browser.cache.disk.smart_size.first_run": false,
    "browser.cache.disk.capacity": 1048576,
    "browser.cache.disk.filesystem_reported": 1,
    "browser.download.importedFromSqlite": true,
    "browser.places.smartBookmarksVersion": 8,
    "browser.sessionstore.upgradeBackup.latestBuildID": "20170205065236",
    "browser.startup.homepage_override.buildID": "20170205065236",
    "browser.startup.homepage_override.mstone": "51.0.1",
    "browser.tabs.remote.autostart": true,
    "browser.urlbar.lastSuggestionsPromptDate": 20170301,
    "browser.urlbar.daysBeforeHidingSuggestionsPrompt": 3,
    "extensions.lastAppVersion": "51.0.1",
    "media.gmp.storage.version.observed": 1,
    "network.cookie.prefsMigrated": true,
    "places.history.expiration.transient_current_max_pages": 122334,
    "plugin.importedState": true,
    "plugin.disable_full_page_plugin_for_types": "application/pdf"
  },
  "lockedPreferences": {},
  "javaScript": {
    "incrementalGCEnabled": true
  },
  "accessibility": {
    "isActive": false,
    "forceDisabled": 0
  },
  "libraryVersions": {
    "NSPR": {
      "minVersion": "4.13.1",
      "version": "4.13.1"
    },
    "NSS": {
      "minVersion": "3.28.1",
      "version": "3.28.1"
    },
    "NSSUTIL": {
      "minVersion": "3.28.1",
      "version": "3.28.1"
    },
    "NSSSSL": {
      "minVersion": "3.28.1",
      "version": "3.28.1"
    },
    "NSSSMIME": {
      "minVersion": "3.28.1",
      "version": "3.28.1"
    }
  },
  "userJS": {
    "exists": false
  },
  "crashes": {
    "submitted": [],
    "pending": 0
  },
  "sandbox": {
    "hasSeccompBPF": true,
    "hasSeccompTSync": true,
    "hasPrivilegedUserNamespaces": true,
    "hasUserNamespaces": false,
    "canSandboxMedia": true
  },
  "extensions": [
    {
      "name": "Add-on Compatibility Reporter",
      "version": "2.2.3",
      "isActive": true,
      "id": "compatibility@addons.mozilla.org"
    },
    {
      "name": "Application Update Service Helper",
      "version": "1.0",
      "isActive": true,
      "id": "aushelper@mozilla.org"
    },
    {
      "name": "Multi-process staged rollout",
      "version": "1.7",
      "isActive": true,
      "id": "e10srollout@mozilla.org"
    },
    {
      "name": "Pocket",
      "version": "1.0.5",
      "isActive": true,
      "id": "firefox@getpocket.com"
    },
    {
      "name": "Web Compat",
      "version": "1.0",
      "isActive": true,
      "id": "webcompat@mozilla.org"
    }
  ],
  "experiments": [],
  "graphics": {
    "numTotalWindows": 1,
    "numAcceleratedWindows": 0,
    "windowLayerManagerType": "Basic",
    "windowLayerManagerRemote": true,
    "supportsHardwareH264": "No",
    "currentAudioBackend": "pulse",
    "numAcceleratedWindowsMessage": [
      ""
    ],
    "adapterDescription": "X.Org -- Gallium 0.4 on AMD CAYMAN (DRM 2.48.0 / 4.9.0-1-amd64, LLVM 3.9.1)",
    "adapterVendorID": "X.Org",
    "adapterDeviceID": "Gallium 0.4 on AMD CAYMAN (DRM 2.48.0 / 4.9.0-1-amd64, LLVM 3.9.1)",
    "adapterRAM": "",
    "adapterDrivers": "",
    "driverVersion": "3.0 Mesa 13.0.4",
    "driverDate": "",
    "webglRenderer": "X.Org -- Gallium 0.4 on AMD CAYMAN (DRM 2.48.0 / 4.9.0-1-amd64, LLVM 3.9.1)",
    "webgl2Renderer": "X.Org -- Gallium 0.4 on AMD CAYMAN (DRM 2.48.0 / 4.9.0-1-amd64, LLVM 3.9.1)",
    "info": {
      "AzureCanvasBackend": "skia",
      "AzureCanvasAccelerated": 0,
      "AzureFallbackCanvasBackend": "none",
      "AzureContentBackend": "skia",
      "CairoUseXRender": 0
    },
    "featureLog": {
      "features": [
        {
          "name": "HW_COMPOSITING",
          "description": "Compositing",
          "status": "blocked",
          "log": [
            {
              "type": "default",
              "status": "blocked",
              "message": "Acceleration blocked by platform"
            }
          ]
        },
        {
          "name": "OPENGL_COMPOSITING",
          "description": "OpenGL Compositing",
          "status": "unavailable",
          "log": [
            {
              "type": "default",
              "status": "unavailable",
              "message": "Hardware compositing is disabled"
            }
          ]
        }
      ],
      "fallbacks": []
    },
    "crashGuards": []
  }
}
wagnerand commented 7 years ago

Thank you.

Just to make sure. When you used a fresh profile and installed the add-on compatibility reporter, did Firefox ask for a restart? Also, was e10s enabled by default in that fresh profile?

felipc commented 7 years ago

Hi there, can you tell me the values of the following prefs in about:config:

app.update.channel e10s.rollout.cohort e10s.rollout.cohortSample

felipc commented 7 years ago

Oh, and also extensions.e10s.rollout.policy

ian-kelling commented 7 years ago

I start a fresh profile. in about:support, multiprocess is 0/1 (Disabled) I set browser.tabs.remote.autostart to true. I restart firefox. in about:support multiprocess is 1/1 (Enabled by user) I installed add-on compatibility reporter. firefox asks to restart I accept, and restart firefox. in about:support, multiprocess is 0/1 (Disabled by add-ons) I disable addon compatiblity reported. I restart firefox. in about:support, multiprocess is 1/1 (Enabled by user)

With a little more testing, it seems that installing add-on compatibility reporter will prompt me for restart only if multiprocess is currently enabled.

Config options asked about: app.update.channel;default e10s.rollout.cohort;unsupportedChannel e10s.rollout.cohortSample, no key extensions.e10s.rollout.policy, no key

felipc commented 7 years ago

Thanks.. How did you obtain this copy of Firefox? Is it self-built, downloaded by yourself, or came pre-installed with your distro? Having the app.update.channel pref be the "default" is not the correct way to receive updates, and it's also what's throwing off the e10s configuration (since it requires the app channel to be "release").

simonbcn commented 7 years ago

Same problem on Firefox 52 on Arch Linux. With Firefox 51 it worked well. I've tested it with Firefox from Arch repository and Firefox downloaded from Mozilla FTP.

app.update.channel : release
e10s.rollout.cohort : optedIn
e10s.rollout.cohortSample : 0.378119
extensions.e10s.rollout.policy : 51set1
felipc commented 7 years ago

@simonbcn, which addons do you have installed? Can you paste your about:support?

felipc commented 7 years ago

Ah, does either of you with the problem have LastPass installed?

felipc commented 7 years ago

LastPass v4 (the beta) was recently blocked for Firefox 52

simonbcn commented 7 years ago

Yes, the problem was LastPass v4. And MEGA perhaps too. I have disabled both and now multiprocess is enabled. It would be more useful if Firefox or this addon indicates the addon responsible.

ian-kelling commented 7 years ago

Thanks.. How did you obtain this copy of Firefox? Is it self-built, downloaded by yourself, or came pre-installed with your distro? Having the app.update.channel pref be the "default" is not the correct way to receive updates, and it's also what's throwing off the e10s configuration (since it requires the app channel to be "release").

It's a firefox from debian, unstable repo.

ian-kelling commented 7 years ago

I just upgraded to 52.0-1, also from debian unstable repo, the issue is the same.

Having the app.update.channel pref be the "default" is not the correct way to receive updates, and it's also what's throwing off the e10s configuration (since it requires the app channel to be "release").

So "Disabled by add-ons" is clearly a bug, it should say something like "disabled by release channel".

As far as I'm concerned, getting firefox from my distro is by far the more "correct" way to receive updates. The mozilla.org download for firefox is inferior in many ways by not integrating with my distro.

felipc commented 7 years ago

Ok yeah. By "correct" I mean to receive updates through Mozilla. I imagine debian changes that intentionally in order to manage the software from the distro, though I wish they had chosen a custom name instead of "default" which has a particular meaning inside Firefox. (meaning it was built from source locally).

In any case, this need to be fixed in order to give e10s to debian users. I'll file a bug on bugzilla about it. Thanks for reporting.

felipc commented 7 years ago

Hmm wait a sec, you said that this works on a fresh profile, right? With no addons installed.. So Debian is already making some code customization in order to make e10s work under the "default" channel. But they probably just missed doing the same for the add-ons e10s rollout code. I'll talk with Glandium but this will probably end up being a bug on debian's bug tracker.

wagnerand commented 7 years ago

I am closing this issue as being unrelated to the add-on.

felipc commented 7 years ago

@ian-kelling , can you tell me the value of these three prefs, and whether they are displayed in bold or regular?

browser.tabs.remote.autostart browser.tabs.remote.autostart.2 extensions.e10sBlocksEnabling

ian-kelling commented 7 years ago

browser.tabs.remote.autostart;true, bold browser.tabs.remote.autostart.2, does not exist extensions.e10sBlocksEnabling;true not bold

braiam commented 7 years ago

@felipc Do I go forward and open the bug?

felipc commented 7 years ago

Hey there, I did file this bug, and it's already been fixed: https://bugzilla.mozilla.org/show_bug.cgi?id=1348576

Fixed for Firefox 55, that is.. I'll discuss with release mgmt next week to see how far we can uplift this patch for earlier versions

braiam commented 7 years ago

@felipc heh, I wonder if distros would use patch downstream. On another note, does this also fixes the issue about having to disable all add-ons so browser.tabs.remote.autostart;true actually enables e10s? Or that should get addressed by a different patch?