mozilla / addon-compatibility-reporter

Add-on Compatibility Reporter (Redux)
https://wiki.mozilla.org/AMO:Projects/ACR
17 stars 12 forks source link

Add WebExtension status in add-on columns in the Add-on Manager #78

Closed davidhedlund closed 7 years ago

davidhedlund commented 7 years ago

A common misconception is that web extensions and Electrolysis (e10s, multiprocess) compatible add-ons are the same thing, they are not.

For example, the add-on Cookie Time is

screenshot from 2017-03-28 04 23 21

Thus Add-on Compatibility Reporter should add extra text in the Add-on Manager

wagnerand commented 7 years ago

I think this is out of the scope for this add-on. The add-on is about identifying and reporting compatibility issues, not technologies. Also, space in the Add-ons Manager is quite limited, so adding an even longer text won't improve things.

davidhedlund commented 7 years ago

Also, space in the Add-ons Manager is quite limited, so adding an even longer text won't improve things.

Text can be shortened to simply: "Multiprocess. WebExtension"

grahamperrin commented 7 years ago

From Add-ons in 2017 | Mozilla Add-ons Blog (2016-11-23):

… By the end of 2017, and with the release of Firefox 57, we’ll move to WebExtensions exclusively, and will stop loading any other extension types on desktop. …

Given the enormity of the move, I was extremely surprised by the limited scope of reporting. There's no mention of the limitation (and no mention of multiprocess, Electrolysis or e10s) at https://addons.mozilla.org/firefox/compatibility_firstrun (captured in the Wayback Machine).

Where there's insufficient space for text, please:

Before reporting, and after

add-ons manager

report

I should expect an alert for (at least) Tab Groups. A click on an alert icon might lead to https://addons.mozilla.org/firefox/addon/tab-groups-panorama/

wagnerand commented 7 years ago

There's no mention of the limitation (and no mention of multiprocess, Electrolysis or e10s) at https://addons.mozilla.org/firefox/compatibility_firstrun (captured in the Wayback Machine).

The add-on has no control over that page. Also, that page is supposed to explain how the add-on works. (I agree that it might be better to include it in the add-on.) For updates about add-ons, please follow our blog: http://blog.mozilla.org/addons/

wagnerand commented 7 years ago

Since the ask to include architecture information (i.e. whether the add-on is a WebExtension or not) has come up a couple of times, I want to explain why I think it is out of scope for this add-on:

Right now, I'd rather see that information on AMO where we can show it for all add-ons instead of just the ones you already have installed. At some point, we will probably have to show information in Firefox (whatever that might look like), but having to install an add-on to see whether an add-on is a WebExtension or not seems weird to me.

fanthos commented 7 years ago
var am = Cu.import("resource://gre/modules/AddonManager.jsm", {}).AddonManager;
am.getAddonsByTypes(["extension"], (addonList) => {
    for(var addon of addonList) {
        console.log(addon.name, addon.id, addon.isWebExtension?"webe":(addon.multiprocessCompatible?"e10s":"none"));
    }
});

Run this script in Browser Console(Ctrl+Shift+J in Windows) will list all your extensions are built on WebExtension or it compatible with multiprocess or not.

grahamperrin commented 7 years ago

From the console:

ReferenceError: Cu is not defined

fanthos commented 7 years ago

In firefox 55, the addon manager page will show a label if the addon is legacy addon.

grahamperrin commented 7 years ago

Thanks … I couldn't recall whether the script did anything significantly different.

davidhedlund commented 7 years ago

Yes, just to make it clear: In Firefox 55, the Add-ons Manager page show a LEGACY label if the addon is not a fully developed WebExtension, Hybrid WebExtensions not counting.

Firefox 55.0.3 screenshot from the Add-on Manager (uBlock Origin added for test purpose) screenshot from 2017-09-05 15 10 04

Thank you @fanthos