search

mozilla / addon-recommendation-shield-study

Stand-alone verison of Add-on Recommendation for Shield Study
Mozilla Public License 2.0
3 stars 7 forks source link

Add-on removes itself when disabled #14

Closed Osmose closed 8 years ago

Osmose commented 8 years ago

If I disable the add-on from about:addons, the add-on shows the post-study survey and removes itself. Showing the survey makes sense to me, but I find it weird that an add-on I only meant to disable automatically removes itself. I'm not sure if that's the right thing to do, though.

@gregglind Thoughts?

gregglind commented 8 years ago

That is by design. My claim is that we should agressively respond to user intent to end the study.

I could be convinced otherwise. We have heard 0 user complaint before this.

On Jul 29, 2016 2:00 PM, "Michael Kelly" notifications@github.com wrote:

If I disable the add-on from about:addons, the add-on shows the post-study survey and removes itself. Showing the survey makes sense to me, but I find it weird that an add-on I only meant to disable automatically removes itself. I'm not sure if that's the right thing to do, though.

@gregglind https://github.com/gregglind Thoughts?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/mozilla/addon-recommendation-shield-study/issues/14, or mute the thread https://github.com/notifications/unsubscribe-auth/AAKAj8K6sXfpxMx8WpMyl6-DNWVvZLkcks5qak2-gaJpZM4JYeks .

Osmose commented 8 years ago

Nah, sounds fine to me. Thanks!