search

mozilla / addon-recommendation-shield-study

Stand-alone verison of Add-on Recommendation for Shield Study
Mozilla Public License 2.0
3 stars 7 forks source link

"Disable all recommendations" link should be on it's own line #17

Closed Osmose closed 8 years ago

Osmose commented 8 years ago
screen shot 2016-07-29 at 11 43 55 am

(Screenshot also includes the overflow bug from #16)

The link to disable all recommendations should be on it's own line below the paragraph, rather than at the end of the paragraph.

casebenton commented 8 years ago
screen shot 2016-07-29 at 12 39 04 pm

How's this?

Osmose commented 8 years ago

Definitely better!

It could use consistent padding around the edges, and could use some more contrast. http://webaim.org/resources/contrastchecker/ is a good tool for finding what a readable contrast between two colors would be.

As a side note, are there any domains with more than one recommendation? I'd like to test out the behavior when the panel is larger.

casebenton commented 8 years ago

The add-on has 4 recommendations on Facebook, the most out of any domain.