mozilla / addon-recommendation-shield-study

Stand-alone verison of Add-on Recommendation for Shield Study
Mozilla Public License 2.0
3 stars 7 forks source link

recommendation triggered on wrong site #79

Closed designakt closed 8 years ago

designakt commented 8 years ago

I got the RT News add-on recommended on http://meiert.com/en/ which is not a right match. siteenhance-rtcom_on_meiertcom

gregglind commented 8 years ago

I am not conviced that www. is needed for all of these. RT is the oddity here. I claim the others are unlikely to be triggered by accident. I claim F- but R+ .

casebenton commented 8 years ago

I think that the issue occurred because previously my code would just check to see that the recommendation domain is a substring of the current domain. I'm now using sdk/url hostname method for stronger comparison, which includes the subdomain. I added www. for all of the recommendation sites that use it (soundcloud.com does not)