User feedback indicates that wikipedia tab is opened on every startup

[casebenton]

This bug is likely in the onboarding event. In this event, a new tab of wikipedia is opened, and users are shown how to use addon recommendation. The feedback suggests that this event is happening on every startup when it should only happen when the addon is installed.

[raymak]

Could be because of simple prefs being unreliable. See it for yourself:

1- install the addon 2- close Firefox by forcefully killing the process (option+command+esc in mac) 3- open Firefox

[gregglind]

As an alternative: check if the loadReason is 'install' and do orientation then. This avoids prefs completely, and is how I am doing all the new study work.

On Fri, Aug 26, 2016 at 2:50 PM, Kamyar Ardekani notifications@github.com wrote:

Could be because of simple prefs being unreliable. See it for yourself:

1- install the addon 2- close Firefox by forcefully killing the process (option+command+esc in mac) 3 open Firefox

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/mozilla/addon-recommendation-shield-study/issues/89#issuecomment-242834132, or mute the thread https://github.com/notifications/unsubscribe-auth/AAKAj4JqprLezB74lyyEHIPcRlYM6c63ks5qj0N-gaJpZM4JuUD7 .

[gregglind]

Anyone (@osmose, @raymak see if this fixes it)

r? @Osmose

[Osmose]

/me is on PTO, @mythmon is probably better here.

[raymak]

Still the problem with prefs exists. The prefSvc seems to be as unreliable as simple-prefs. I think we can fix this for now with your own solution (only onboard if loadreason is install).

BTW, you can get the load reason easily by getting the "[sdk pref branch].sdk.load.reason" pref.

[gregglind]

Kamyar, I would like to see a video of how you induce it, and see if we can fix this once an for all in product!

GL

On Tue, Aug 30, 2016 at 11:52 PM, Kamyar Ardekani notifications@github.com wrote:

Still the problem with prefs exists. The prefSvc seems to be as unreliable as simple-prefs. I think we can fix this for now with your own solution (only onboard if loadreason is install).

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/mozilla/addon-recommendation-shield-study/pull/89#issuecomment-243657923, or mute the thread https://github.com/notifications/unsubscribe-auth/AAKAjykR1chy-O8nHtP9_4GK7gEmMK18ks5qlQiOgaJpZM4JuUD7 .

[gregglind]

@mython, @raymak... this looking better?

[mythmon]

Since switching to prefSvc doesn't seem to have helped the problem, would it be better to keep using the simplePrefs interface, since it is simpler?

[mythmon]

Also, personally, I think it is better to push new commits instead of force pushing to keep a PR at one commit. That makes it much easier for reviewers to process a PR, since we can see incremental progress if we review multiple times. It creates messier git history, but we look at PRs a lot more than git history, so we should optimize for PRs.

[mythmon]

Oh, and as far as fixing the actual issue, I haven't been able to replicate that, so I leave it to @raymak to determine if the issue is fixed.

[casebenton]

91 Resolves this issue