search

mozilla / addon-wr

Looking Glass is a collaboration between Mozilla and the makers of Mr. Robot to provide a shared world experience.
https://support.mozilla.org/kb/lookingglass
51 stars 15 forks source link

Rename generated XPI file instead of creating a sym-link? #17

Closed pdehaan closed 6 years ago

pdehaan commented 6 years ago

Instead of generating a symbolic link to the generated XPI, why not just do a mv "${XPI_NAME}" addon.xpi? (Or even mv *.xpi addon.xpi, if the /dist/ directory only has one XPI file)

https://github.com/gregglind/addon-wr/blob/526535ea04ce79f59a79381ab71b8c9be61b9af8/bin/xpi.sh#L39-L49

biancadanforth commented 6 years ago

@gregglind , correct me if I am wrong, but I believe one copy (the symlink) is for development, and the other copy is for publishing. There's a naming convention that is adhered to (for tracking in telemetry I assume!), so it's easier to generate this XPI programmatically from details in package.json than to manually create it later on.

gregglind commented 6 years ago

Correct. It makes a real one, and a symlink (that always has a predicatble name 'linked-addon.xpi'. I could change it to be 'copied-addon.xpi'

gregglind commented 6 years ago

(this belongs in https://github.com/mozilla/shield-studies-addon-template though :)

pdehaan commented 6 years ago

Filed upstream as https://github.com/mozilla/shield-studies-addon-template/issues/42 Closing.