search

mozilla / addon-wr

Looking Glass is a collaboration between Mozilla and the makers of Mr. Robot to provide a shared world experience.
https://support.mozilla.org/kb/lookingglass
51 stars 15 forks source link

Audit trigger words #19

Closed pdehaan closed 6 years ago

pdehaan commented 6 years ago

https://github.com/gregglind/addon-wr/blob/16aff7d830938d7c115ae31ade288b1b49155f3c/addon/webextension/background.js#L11

I don’t think “disintigration” is a word. http://www.dictionary.com/misspelling?term=disintigration (me thinks we want “disintegration”, possibly).

Do we want to use "army"? It seems like that could get weird if it's an article about a real live army event on a news site and we inject some styling and tooltips.

Not sure if instead of a string+regex we just do an array of words like this, which gives us a bit more flexibility:

const WORDS = ["dark army", "disintegration", "data", "privacy", "internet", "delete"];
biancadanforth commented 6 years ago

I've corrected the "disintegration" word in the list with my latest PR.

My understanding from @gregglind is that we will receive a list of words from our partners, so these are just a temporary list for now; that said, we can trivially change this as you suggest if needed.

gregglind commented 6 years ago

These are coming in a soon patch.

pdehaan commented 6 years ago

Closing. Latest strings are in #23 PR.