search

mozilla / addon-wr

Looking Glass is a collaboration between Mozilla and the makers of Mr. Robot to provide a shared world experience.
https://support.mozilla.org/kb/lookingglass
51 stars 15 forks source link

Audit APPLICABLE_PROTOCOLS #20

Closed pdehaan closed 6 years ago

pdehaan commented 6 years ago

https://github.com/gregglind/addon-wr/blob/16aff7d830938d7c115ae31ade288b1b49155f3c/addon/webextension/background.js#L141

We were discussing earlier today on Vidyo, but just confirming that we :100: want to modify ftp: and file: protocols.

biancadanforth commented 6 years ago

@pdehaan , do you mean remove them from the list? Can you elaborate?

pdehaan commented 6 years ago

@biancadanforth Basically I was just looking for confirmation that we wanted to modify files from ftp:// and file:// protocols and limit this to just /https?/.

gregglind commented 6 years ago

File yes. That's how we do local testing. Ftp: I have no idea of how users can / would even open ftp links! I think it's safe enough, but if we want to remove it, I have no objection.

pdehaan commented 6 years ago

Ref: #23 PR.