search

mozilla / addon-wr

Looking Glass is a collaboration between Mozilla and the makers of Mr. Robot to provide a shared world experience.
https://support.mozilla.org/kb/lookingglass
51 stars 15 forks source link

WIP on less sublte effect. #24

Closed gregglind closed 6 years ago

gregglind commented 6 years ago

KNONW ISSUE:

  1. The hover box takes a bit to disappear.
  2. The hover box flips over when the span does.

Possible answere:

  1. On hover handler for teh flipped spans, rather than pure css?
biancadanforth commented 6 years ago

For posterity, there is one known unresolved display bug for when parent elements to the match word (.donotdelete element) have overflow:hidden applied. This occurs on Google search page for "army" for example.

Since it's hard to anticipate all possible inherited styles; we may want to consider a different approach in the future than appending the hover element as a child element to the match word .donotdelete element.

One idea: attach a single hover element to <body> (and apply a neutralizing styles boilerplate to the element), and anchor it to the mouse location when the user hovers over a match word. In this case, since the element is a child of <body> rather than a potentially deeply nested unknown element, we can expect it to inherit a much smaller variety of styles, and therefore can hope to have much better control.