mozilla / addons-code-manager

A web application to manage add-on source code
Mozilla Public License 2.0
27 stars 36 forks source link

Render historic comments for files, inline #717

Open kumar303 opened 5 years ago

kumar303 commented 5 years ago

Describe the problem and steps to reproduce it:

Consider this imaginary UI flow:

What happened?

n/a

What did you expect to happen?

The older comments should be displayed when viewing an already reviewed version

Anything else we should know?

This depends on https://github.com/mozilla/addons/issues/6647

This is similar to viewing draft comments: https://github.com/mozilla/addons-code-manager/issues/713

┆Issue is synchronized with this Jira Task

EnTeQuAk commented 5 years ago

With mozilla/addons#6647 being fixed, I'm going to remove the needs: api label for now. Let me know if you need anything specific on top of that.

kumar303 commented 4 years ago

We do have an API to list comments but I think it needs some tweaks to support this issue. See https://github.com/mozilla/addons/issues/7118