mozilla / addons-linter

🔍 Firefox Add-ons linter, written in JavaScript. 👁
Mozilla Public License 2.0
319 stars 144 forks source link

Output as list, not table #5423

Open fregante opened 3 months ago

fregante commented 3 months ago

Describe the problem and steps to reproduce it:

I'm not a fan of the table output, it's repetitive and it breaks file names on small terminals.

Current

Code                              Message           Description                      File      
MANIFEST_FIELD_UNSUPPORTED        "/background/s…   "/background/service_worker"     ma
                                  ervice_worker"    is not supported.                          
                                  is not                                                       
                                  supported.                                                   
KEY_FIREFOX_UNSUPPORTED_BY_MIN…   Manifest key      "strict_min_version" requires    manife
_VERSION                          not supported     Firefox 126, which was                 
                                  by the            released before version 128                
                                  specified         introduced support for                     
                                  minimum Firefox   "optional_host_permissions".               
                                  version                                                      
KEY_FIREFOX_ANDROID_UNSUPPORTE…   Manifest key      "strict_min_version" requires    manife
D_BY_MIN_VERSION                  not supported     Firefox for Android 126, which         
                                  by the            was released before version                
                                  specified         128 introduced support for                 
                                  minimum Firefox   "optional_host_permissions".               
                                  for Android                                                  
                                  version                                                      
UNSAFE_VAR_ASSIGNMENT             Unsafe            Due to both security and         as
                                  assignment to     performance concerns, this may   dules/dom-
                                  innerHTML         not be set using dynamic         /index.js 
                                                    values which have not been                 
                                                    adequately sanitized. This can             
                                                    lead to security issues or                 
                                                    fairly serious performance                 
                                                    degradation.                               
UNSAFE_VAR_ASSIGNMENT             Unsafe            Due to both security and         as
                                  assignment to     performance concerns, this may   dules/doma
                                  innerHTML         not be set using dynamic         ex.js     
                                                    values which have not been                 
                                                    adequately sanitized. This can             
                                                    lead to security issues or                 
                                                    fairly serious performance                 
                                                    degradation.                               
UNSAFE_VAR_ASSIGNMENT             Unsafe call to    Due to both security and         as
                                  document.creat…   performance concerns, this may   dules/link
                                  eRange().creat…   not be set using dynamic         issues/ind
                                  eContextualFra…   values which have not been                 
                                  gment for         adequately sanitized. This can             
                                  argument 0        lead to security issues or                 
                                                    fairly serious performance                 
                                                    degradation.                               
UNSAFE_VAR_ASSIGNMENT             Unsafe call to    Due to both security and         as
                                  document.creat…   performance concerns, this may   dules/link
                                  eRange().creat…   not be set using dynamic         urls/index
                                  eContextualFra…   values which have not been                 
                                  gment for         adequately sanitized. This can             
                                  argument 0        lead to security issues or                 
                                                    fairly serious performance                 
                                                    degradation.                    

Ideal

MANIFEST_FIELD_UNSUPPORTED
  "/background/service_worker" is not supported.
  "/background/service_worker" is not supported.
  manifest.json

KEY_FIREFOX_UNSUPPORTED_BY_MIN_VERSION
  Manifest key not supported by the specified minimum Firefox version
  "strict_min_version" requires Firefox 126, which was released before version 128 introduced support for "optional_host_permissions".
  manifest.json

KEY_FIREFOX_ANDROID_UNSUPPORTED_BY_MIN_VERSION
  Manifest key not supported by the specified minimum Firefox for Android version
  "strict_min_version" requires Firefox for Android 126, which was released before version 128 introduced support for "optional_host_permissions".
  manifest.json

UNSAFE_VAR_ASSIGNMENT
  Unsafe assignment to innerHTML
  Due to both security and performance concerns, this may not be set using dynamic values which have not been adequately sanitized. This can lead to security issues or fairly serious performance degradation.
  assets/node_modules/dom-chef/index.js:96:13
  assets/node_modules/doma/index.js:6:5
  assets/node_modules/linkify-issues/index.js:20:24
  assets/node_modules/linkify-urls/index.js:15:24