search

mozilla / addons

☂ Umbrella repository for Mozilla Addons ✨
Other
127 stars 41 forks source link

Pressing on the label “Press to Preview” flashes the theme over another theme that is already installed #10064

Closed cosminbadescuSV closed 7 years ago

cosminbadescuSV commented 7 years ago

Describe the problem and steps to reproduce it:

Install a theme, then press on the label “Press to Preview” from another theme.

What happened?

After pressing on the label “Press to Preview”, the theme you want to preview flashes over the installed theme.

What did you expect to happen?

Pressing on the label “Press to Preview” should not flash the theme you want to preview over the installed theme.

Anything else we should know?

Press&hold will display the theme you want to preview, until you release it. Verified on FF51.0 (Android 7.1.1) in AMO-dev server.

Here is a video: flash

muffinresearch commented 7 years ago

Needs investigating to find out why this is happening.

mstriemer commented 7 years ago

I'm not sure what's going on here. This looks like the intended behaviour. If you press and hold it shows you the theme you want to preview.

Is it that tapping the "button" does something weird?

cosminbadescuSV commented 7 years ago

One tap on the theme will cause the flash, I did not performed a “press and hold” for this issue. It is hard for me to catch the flash in the video because tapping on the theme will be interpreted as “press and hold” in the video which in this case isn’t. Video for this issue: anos

muffinresearch commented 7 years ago

We discussed this feature in a triage yesterday and thought that it might make sense to make this work on a click with requiring click to turn off the preview.

Holding a press is a little bit counter-intuitive and probably "Press to preview" doesn't give enough of a hint to hold the press. A click might be simpler for users to understand.

We'd probably want to consider having the preview be dismissed if the user clicks something else / navigates away from the page too.

muffinresearch commented 7 years ago

Will be solved by mozilla/addons#10119

cosminbadescuSV commented 7 years ago

This issue is verified as fixed on FF51.0 (Android 7.1.1) on -dev server. The theme you want to preview will not flash over the installed theme, it will disappear after you tap on the theme to cancel the preview. Please see the video: videotogif_2017 03 01_17 16 07