search

mozilla / addons

☂ Umbrella repository for Mozilla Addons ✨
Other
127 stars 41 forks source link

No content in Themes categories #10086

Closed ValentinaPC closed 7 years ago

ValentinaPC commented 7 years ago

Steps to reproduce:

  1. Load AMO-dev on your Android device
  2. Click on any theme category i.e Wild

Expected results: Themes are displayed.

Actual results: No themes displayed.

Notes/Issues:

Verified on AMO-dev FF51(Android 6.0.1) Screenshot for this issue: wt

tofumatt commented 7 years ago

The API is returning 400 Bad Request for this combo of Android/Persona (Theme)/Wild. Possibly all themes. Will investigate; I hope these aren't all desktop-only categories 😒

tofumatt commented 7 years ago

Further investigation confirms that Android/Theme/Wild is not a valid combo. In fact: none of our categories work for themes for mobile. 😢

So we will need all new illustrations for a set of mobile themes from this list: https://addons-server.readthedocs.io/en/latest/topics/api/categories.html#current-categories

OH NO. Actually there are no mobile theme categories. So we'll need to make some. For now it seems we should remove the themes categories from the home page.

I would say this is pretty important as it throws off the homepage a lot. We'll need to create the categories and then add the right themes to them 😒

tofumatt commented 7 years ago

Note: in this case we may need to request personas without asking for android ones, as any persona will work on Android.

(And eventually patch the API but that might be more work so we'll patch the request from the frontend for now.)

ValentinaPC commented 7 years ago

Verified as fixed on FF51(Android 6.0.1) Postfix video: videotogif_2017 03 03_09 17 53