mozilla / addons

☂ Umbrella repository for Mozilla Addons ✨
Other
127 stars 41 forks source link

No design displayed for some themes on mobile #10126

Closed ValentinaPC closed 7 years ago

ValentinaPC commented 7 years ago

Steps to reproduce:

  1. Load AMO-dev on your Android device and search something i.e. "wild" (https://addons-dev.allizom.org/en-US/android/search/?q=wild)
  2. Scroll through results and observe all themes

Expected results: Every theme has a design.

Actual results: Some themes don't have a design.

Notes/Issues:

Verified on FF51(Android 6.0.1). Screenshots for this issue: nodesign

muffinresearch commented 7 years ago

This might be resolved by https://github.com/mozilla/addons/issues/10105

ValentinaPC commented 7 years ago

Unfortunately this was not fixed by mozilla/addons#10105. There are still some themes that have no design preview after search. I.e: 1

Notes:

See video: videotogif_2017 02 23_15 13 17

muffinresearch commented 7 years ago

This is due to the image files being 404. I think this might be a data problem or data import related.

muffinresearch commented 7 years ago

I'll investigate this one to see what's going on.

muffinresearch commented 7 years ago

Having added a test theme the images appeared to be generated correctly. I think this is purely a data issue but we should re-open this if we see it on stage.

ValentinaPC commented 7 years ago

This seems to be fixed in mozilla/addons#10194 . Verified as fixed in AMO-dev FF51(Android 6.0.1). Postfix video: videotogif_2017 03 06_14 35 32