mozilla / addons

☂ Umbrella repository for Mozilla Addons ✨
Other
127 stars 41 forks source link

Search placeholder overflows for non-en locales #10206

Closed ghost closed 7 years ago

ghost commented 7 years ago

Steps to reproduce :

  1. open https://addons-dev.allizom.org/en-US/firefox/ in Android
  2. hen at the bottom of the page , change the language from English to something else

Actual Result:

The search bar string crosses the mobile window. Then to read the whole string , scrolling the screen to the right is needed.

Expected Result :

The string should have been between the screen. It should not cross the screen size.

Attachment -

  1. https://drive.google.com/open?id=0B75_JfziYeofd3BndktvRXZYLTg
  2. https://drive.google.com/open?id=0B75_JfziYeofTElzNnRRazRwMDA
muffinresearch commented 7 years ago

@mMARUF feel free to drop screenshots straight into bug descriptions it helps us to see the problem more directly without cross-referencing.

muffinresearch commented 7 years ago

@mMARUF thanks for the bug report by they way, good catch.

muffinresearch commented 7 years ago

The patch for this is a quick fix to stop the layout breaking but we should look at a better fix to not hide part of the placeholder in locales that have longer text.

ValentinaPC commented 7 years ago

Verified this on AMO-dev FF51(Android 6.0.1)

But, typed text in the search field is not displayed. Please see video: videotogif_2017 03 08_10 48 13

@muffinresearch : Please let me know if reopening this should be ok, or logging another is better.

muffinresearch commented 7 years ago

@ValentinaPC please open a new bug with a "blocks release" label

Fwiw I've tested and it's not a regression from this change.

ValentinaPC commented 7 years ago

Thanks! Marking this verified-fixed.