Existing user cannot sign in on AMO-dev without clearing cookies

mozilla / addons

☂ Umbrella repository for Mozilla Addons ✨

Other

127 stars 41 forks source link

Existing user cannot sign in on AMO-dev without clearing cookies #10292

Closed ValentinaPC closed 7 years ago

ValentinaPC commented 7 years ago

Steps to reproduce:

Load AMO-dev page on mobile https://addons-dev.allizom.org/en-US/android/
Try to sign in

Expected results: User is signed in.

Actual results: User is not signed in.

Notes/Issues:

FxA page works as expected, but user seems logged out.
if same steps are tried on desktop, with "mobile site view" on, user is signed in

Verified on FF52(Android 6.0.1). Issue is only reproducing on AMO-dev. Video for this issue: videotogif_2017 03 23_11 37 19

kumar303 commented 7 years ago

If you empty your cache on Firefox for Android, refresh the page, and try again does it work?

ValentinaPC commented 7 years ago

If you empty your cache on Firefox for Android, refresh the page, and try again does it work?

Yes.

kumar303 commented 7 years ago

ok, thanks. What happened is the code for handling login/logout changed. We need to think of a way to bust the cache automatically for changes like this.

kumar303 commented 7 years ago

I added https://github.com/mozilla/addons-frontend/issues/2157 to show STR that can be performed in a fresh browser session.

kumar303 commented 7 years ago

This has been fixed by https://github.com/mozilla/addons-server/pull/5030