search

mozilla / addons

☂ Umbrella repository for Mozilla Addons ✨
Other
125 stars 41 forks source link

Integrate <LoadingBar> into callApi calls #10304

Closed tofumatt closed 6 years ago

tofumatt commented 7 years ago

Currently we only render the loading bar if reduxConnect dispatches an action we interpret as loading/finished loading. This means direct calls to the API like in the Ratings component won't render the loading bar. We should pass dispatch to those callApi calls and dispatch in callApi.

kumar303 commented 7 years ago

We may need to introduce thunk to make it easier to use dispatch in callApi().

Ryuno-Ki commented 7 years ago

I've looked into the source code of that react loading bar library. It seems to just style a <div>, so AT users wouldn't be informed.

Shall I open a new issue about it?

tofumatt commented 6 years ago

We aren't going to do this because we now use <LoadingText>

ValentinaPC commented 6 years ago

Please add some STR for us to check his or the label "qa: not needed". Thanks!