search

mozilla / addons

☂ Umbrella repository for Mozilla Addons ✨
Other
127 stars 41 forks source link

Loading bar has dissappeared #10383

Closed muffinresearch closed 7 years ago

muffinresearch commented 7 years ago

The loading bar has dissappeared from the mobile site.

There's no loading bar shown when navigating or doing an action that fetches data on -dev, stage or prod.

muffinresearch commented 7 years ago

Potentially related to the last update [1] but needs investigation.

[1] https://github.com/mozilla/addons-frontend/pull/2349

tofumatt commented 7 years ago

QA: To verify you should see the blue loading bar on the top of the page when nagivating from the home page to the "Extensions" or "Themes" link on the homepage (really, anything from the homepage but just trying to make it easy to repro–there are a few links like navigating back to the homepage that won't show the loading bar because they don't make any async requests and are instant).

kumar303 commented 7 years ago

It's a mystery as to what caused this. Here is all that changed in the package https://github.com/mironov/react-redux-loading-bar/compare/762fa369691aab52df550b1a2b2ee742b2b70b2a...cfb35014376fbd7c01e2a04f5b1a04573a46113a

ValentinaPC commented 7 years ago

While being focused on the fact that the puzzle placeholder was missing, did not observed that the loading indicator was missing too (https://github.com/mozilla/addons/issues/9904)

Verified this on AMO-dev FF53(Win 7) and observed a loading indicator in 2 colors:

@muffinresearch : Please let me know if the 2 colors are intended.