mozilla / addons

☂ Umbrella repository for Mozilla Addons ✨
Other
123 stars 53 forks source link

Installation is not working for themes/extensions on AMO-dev #10425

Closed ValentinaPC closed 6 years ago

ValentinaPC commented 6 years ago

Steps to reproduce:

  1. Load any theme/extensions details page on your Android device i.e. https://addons-dev.allizom.org/en-US/android/addon/shamrocks2/
  2. Observe the install button

Expected results: The installation button is enabled.

Actual results: The installation button is disabled.

Notes/Issues:

Verified on FF53(Android 6.0.1, 7.1.2). Video for this issue: videotogif_2017 05 29_12 41 06

muffinresearch commented 6 years ago

@ValentinaPC based on the version you're quoting this isn't nightly. Release doesn't allow the prefs for testing.

Please re-open if this is a problem on nightly.

muffinresearch commented 6 years ago

I'm going to re-open this because it suggests that something might be broken causing the fallback buttons not to be displayed.

muffinresearch commented 6 years ago

This is caused by Intl not being available on FF Android. See also https://bugzilla.mozilla.org/show_bug.cgi?id=1215247

ReferenceError: Intl is not defined

The fix will be to fallback to our previous solution for this case. It's apparently coming in 54.

ValentinaPC commented 6 years ago

Verified as fixed on AMO-dev FF53(Android 7.1.2). Installation is working for add-ons and themes. Postfix video: videotogif_2017 05 31_12 27 37

ValentinaPC commented 6 years ago

This is happening again, together with mozilla/addons#10426 .

Also some other weird stuff:

ValentinaPC commented 6 years ago

Was logged - mozilla/addons#10451