mozilla / addons

☂ Umbrella repository for Mozilla Addons ✨
Other
123 stars 53 forks source link

Add-ons installation button is disabled #10453

Closed ValentinaPC closed 6 years ago

ValentinaPC commented 6 years ago

Steps to reproduce:

  1. Load any add-on details page on your Android device i.e. https://addons.allizom.org/en-US/android/addon/phony/?src=hp-dl-featured
  2. Observe the installation button

Expected results: The button is enabled.

Actual results: The button is disabled.

Notes/Issues:

Screenshots for this issue: 2017-06-07_1224

muffinresearch commented 6 years ago

I'm looking into it...

muffinresearch commented 6 years ago

It's a regression from https://github.com/mozilla/addons-frontend/commit/0a0e650b25deb74841802e387f93920eda02135d - reverting that commit restores expected functionality.

muffinresearch commented 6 years ago

This won't revert cleanly on master but a revert on the tag will work if we need to just get things working as quickly as possible and take more time with the patch for master.

muffinresearch commented 6 years ago

@kumar303 also let me know if you need any help with reproducing this locally.

muffinresearch commented 6 years ago

Actually I'm going to go ahead and revert in the tag to unblock QA sooner.

muffinresearch commented 6 years ago

Reverted for the tag see https://github.com/mozilla/addons-frontend/compare/2017.06.01...2017.06.08-2

@ValentinaPC this will mean it should be fixed on stage (once deployed shortly) but won't be fixed on -dev. Leaving this bug open to track the fix that needs to land in master.

tofumatt commented 6 years ago

Shoot, sorry I didn't notice this myself.

ValentinaPC commented 6 years ago

Verified this on stage while using FF53(Android 7.1.2). The install button is enabled (verified also for Nightly) Video: videotogif_2017 06 07_19 12 26

ValentinaPC commented 6 years ago

Depends on mozilla/addons#10459