mozilla / addons

☂ Umbrella repository for Mozilla Addons ✨
Other
127 stars 41 forks source link

Install button is disabled in AMO-stage #10595

Closed ValentinaPC closed 7 years ago

ValentinaPC commented 7 years ago

Steps to reproduce:

  1. Load details page for an add-on on your Android device i.e. https://addons.allizom.org/en-US/android/addon/bluhell-firewall/
  2. Observe the installation button

Expected results: The button is active.

Actual results: The button is not active.

Notes/Issues: Verified on FF54(Android 7.1.2, win 7). Issue is only reproducing on stage.

muffinresearch commented 7 years ago

I can't repro this on Android Nightly or Firefox Desktop Nightly on OSX

ValentinaPC commented 7 years ago

Tried on desktop, on a new fresh-clean Nightly profile and the install button is active but at click a js error is displayed in the console. Please see screenshot: js

tofumatt commented 7 years ago

The install fail on a fresh profile if the signatures for dev/stage aren't enabled: https://github.com/mozilla/addons-frontend/blob/master/docs/moz-addon-manager.md#install-add-ons-for-development

I can see in that console screenshot above it's complaining about bad signatures, so enabling them should fix the issue.

ValentinaPC commented 7 years ago

I know what you mean, but the pref does not change the initial issue: install button is still disabled. After searching deeper I came to the conclusion that, without any prefs set, dev and stage are different in what concerns the install buttons: dev stage

Maybe this will help you in discovering why installation does not work on stage.

ValentinaPC commented 7 years ago

Seems like something fixed this issue. :)

muffinresearch commented 7 years ago

@ValentinaPC are we ok to close this on the basis of re-opening if it happens again? It's a bit odd, I'd like to know the root cause, but I suspect if it's no longer reproducible that will be difficult.

muffinresearch commented 7 years ago

Since mozilla/addons#10596 has similarly resolved itself I'm going to close this. But feel free to reopen if it re-occurs.