mozilla / addons

☂ Umbrella repository for Mozilla Addons ✨
Other
127 stars 41 forks source link

Navigation after an empty search in Extensions/Themes homepages is broken #10672

Closed ValentinaPC closed 7 years ago

ValentinaPC commented 7 years ago

Steps to reproduce:

  1. Make an empty search in Extensions homepage https://addons-dev.allizom.org/en-US/firefox/search/?type=extension
  2. Navigate to last pages i.e. page 500 - https://addons-dev.allizom.org/en-US/firefox/search/?app=firefox&page=500&type=extension

Expected results: Results are listed.

Actual results: Page is somehow broken.

Notes/Issues:

May be a regression from mozilla/addons#10523 ?

tofumatt commented 7 years ago

Looks like this is related to the number of pages we're showing–they aren't accurate. Navigating to 400 works but 401 also renders an error.

It seems our page numbers are inaccurate.

tofumatt commented 7 years ago

Looks like this is a dupe of mozilla/addons#10197, basically–we don't use the right info from the API so we render the wrong number of pages.