search

mozilla / addons

☂ Umbrella repository for Mozilla Addons ✨
Other
127 stars 41 forks source link

Theme loading indicators do not match the content #10762

Closed muffinresearch closed 5 years ago

muffinresearch commented 7 years ago

The loading indicators for themes is the same as the one for add-ons this results in the page jumping around when the data loads because themes contain a larger image and not just text and an icon.

STR:

Go to https://addons-dev.allizom.org/en-US/firefox/themes/ and watch the themes load.

Loading state:

untitled

Loaded content:

add-ons_for_firefox
ioanarusiczki commented 5 years ago

@willdurand I can see the "No theme preview available" when I load the themes page (it's more obvious on Android). However, most of the time the themes load pretty quickly and that empty preview is not present at all.

themestab

Verified on AMO dev with FF69(Win10) and FF 68.1.1 (Android 8.0)

willdurand commented 5 years ago

@willdurand I can see the "No theme preview available" when I load the themes page (it's more obvious on Android). However, most of the time the themes load pretty quickly and that empty preview is not present at all.

Yes, that is intended.