search

mozilla / addons

☂ Umbrella repository for Mozilla Addons ✨
Other
127 stars 41 forks source link

Unusable "See all versions" for themes #10828

Closed ValentinaPC closed 7 years ago

ValentinaPC commented 7 years ago

Steps to reproduce:

  1. Load details page for a theme i.e. https://addons.allizom.org/en-US/firefox/addon/summer-ladybug/
  2. Observe "More information" section

Expected results: There is no "See all versions" link for themes.

Actual results: There is a "See all versions" link fro themes that redirects to an extension empty "version history" page.

Notes/Issues: Verified on AMO-stage FF55/FF58(Win 7, Android 7.2.1). Video for this issue: all vrs

tofumatt commented 7 years ago

The fix here is to not show that link on themes, which seemingly do not have a version history.

tofumatt commented 7 years ago

Because themes don't have a version we should also omit the "version" info on the More Information card–it's always "0".

Because we don't know the add-on type before it loads we can't show certain bits of loading info either, we'll need to hide the version and version history loading indicators as well.

ValentinaPC commented 7 years ago

Verified as fixed on AMO-dev FF56(Win 7). Not version information is listed in themes details page. Postfix screenshot: no_vers