search

mozilla / addons

☂ Umbrella repository for Mozilla Addons ✨
Other
125 stars 41 forks source link

Add-ons incompatible with your platform look installable #10829

Closed ValentinaPC closed 6 years ago

ValentinaPC commented 6 years ago

Steps to reproduce:

  1. Load details page for an add-on that is not compatible with your platform i.e. https://addons.allizom.org/en-US/firefox/addon/webext-no-platf/
  2. See the installation button

Expected results: The install button is disabled. A red banner saying that the add-on is not compatible with your platform is displayed.

Actual results: No banner regarding the add-on platform incompatibility. Install button is enabled. At click the switch is moved but the color is not turned to green. Add-on is not installed.

Notes/Issues: Verified on AMO-stage FF55(Win 7). Issue is also reproducing on -dev.

tofumatt commented 6 years ago

@kumar303, I wonder if this is related to the new platform install feature?

On 28 Sep 2017, at 09:38, ValentinaPC notifications@github.com wrote:

Steps to reproduce:

Load details page for an add-on that is not compatible with your platform i.e. https://addons.allizom.org/en-US/firefox/addon/webext-no-platf/ See the installation button Expected results: The install button is disabled. A red banner saying that the add-on is not compatible with your platform is displayed.

Actual results: No banner regarding the add-on platform incompatibility. Install button is enabled. At click the switch is moved but the color is not turned to green. Add-on is not installed.

Notes/Issues: Verified on AMO-stage FF55(Win 7). Issue is also reproducing on -dev.

refreshing the page will put the switch button in its correct position. Screenshot for this issue:

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or mute the thread.

muffinresearch commented 6 years ago

@ValentinaPC could you provide details of which platforms are selected for this add-on?

ValentinaPC commented 6 years ago

@muffinresearch 👍

kumar303 commented 6 years ago

I wonder if this is related to the new platform install feature?

Yes, sort of. What's happening here is that no install URL exists for the add-on since it doesn't support the platform. However, why did the code even get that far.

ValentinaPC commented 6 years ago

Verified as fixed on AMO-dev FF56(Win 7). Postfix screenshot: no_plat