mozilla / addons

☂ Umbrella repository for Mozilla Addons ✨
Other
125 stars 41 forks source link

Redirect to seamonkey and thunderbird apps via user agent #11071

Closed kumar303 closed 6 years ago

kumar303 commented 6 years ago

Describe the problem and steps to reproduce it:

What happened?

You are redirected to https://addons-dev.allizom.org/en-US/firefox/

What did you expect to happen?

Anything else we should know?

muffinresearch commented 6 years ago

Duplicate of https://github.com/mozilla/addons/issues/11066

muffinresearch commented 6 years ago

@kumar303 not sure if this is at cross purposes with mozilla/addons#11066? That issue was about making sure SeaMonkey and Thunderbird UAs only ever see the legacy site at the nginx level not just based on paths - path handling was already in place also at the nginx level.

Let me know if I've misunderstood anything.

kumar303 commented 6 years ago

@muffinresearch I'm confused. The STR up above on dev lands me https://addons-dev.allizom.org/en-US/firefox/ but it should land me at https://addons-dev.allizom.org/en-US/thunderbird/ (or seamonkey). With my patch it will do so.

muffinresearch commented 6 years ago

We talked about this on irc, the confusion was caused by kumar's UA extension not setting the test UA correctly.

kumar303 commented 6 years ago

Yeah, I was experiencing some kind of bug where the UA was not getting applied to the request.

The clarification I was missing is that nginx will inspect the user agent. It always serves the legacy site to seamonkey/thunderbird UAs and the legacy site does redirects as expected.