Broken link from mozilla privacy campaign

kenrin commented 7 years ago

Describe the problem and steps to reproduce it:

The link https://addons.mozilla.org/firefox/collections/mozilla/privacy/ is broken. I followed the link from the website https://www.mozilla.org/en-US/teach/smarton/tracking/ which was one of the start page privacy information links.

What happened?

What did you expect to happen?

I expected it to take me to a collection of mozilla privacy addons and it took me to a broken page to report the issue.

Anything else we should know?

wagnerand commented 7 years ago

@devaneymoz did we delete that collection?

kumar303 commented 7 years ago

@kenrin thanks for the bug report.

Hi @jpetto do you know anything about this link?

I'm marking this as high priority since it's a highly visible 404. The link appears here:

jpetto commented 7 years ago

I know those SmartOn pages are pretty old, and that it's relatively easy to update the link. 😁 What URL should we point it to?

wagnerand commented 7 years ago

I have found https://addons.mozilla.org/en-US/firefox/collections/mozilla/privacy-matters/ which could be the one, but @devaneymoz should confirm.

wagnerand commented 7 years ago

Also, for the record, we could also update the slug on our end to be .../privacy if we want that.

devaneymoz commented 7 years ago

Thank you for raising this issue! The title of the collection recently changed, and automatically altered the slug. My preferred fix would be to update the mozilla.org page with the new URL ( /privacy-matters/ ), since other areas including AMO homepage point to the new URL.

Can we do that?

jpetto commented 7 years ago

We can update the URL to anything you'd like. Should it be updated to the following?

https://addons.mozilla.org/firefox/collections/mozilla/privacy-matters/

willdurand commented 7 years ago

@jpetto yes

muffinresearch commented 7 years ago

@bqbn would it be possible to setup a 301 redirect in nginx for both:

/%locale%/(firefox|android)/collections/mozilla/privacy/ -> /%locale%/(firefox|android)/collections/mozilla/privacy-matters/ where %locale% represents any locale e.g. en-US.
/(firefox|android)/collections/mozilla/privacy/ -> /(firefox|android)/collections/mozilla/privacy-matters/ this is a non-locale prefixed link which saves hitting the app first to get a country code to then do the first redirect.

(firefox|android) should match either firefox or android

Doing this at the nginx level makes sense since this impacts both the old and new site. We can't change the slug and it would be good to have a redirect in place in case of additional backlinks and bookmarks.

kumar303 commented 7 years ago

Do we still need to set up the redirects? https://www.mozilla.org/en-US/ has been fixed with the correct link in https://github.com/mozilla/bedrock/pull/5292 (thanks @jpetto !)

willdurand commented 7 years ago

Maybe this collection is linked in other places too? If it is an important collection, that would be still worthwhile.

jpetto commented 7 years ago

On moz.org, we generally do set up redirects for this kind of thing. You never know how many links might be out there.

muffinresearch commented 6 years ago

Here's some testing examples for when the redir config change hits dev/stage/prod.

These should work on both on the old and new frontends since the redir is happening above both in nginx.

Example Urls to test on -dev:

Example Urls to test on stage:

Example urls to test in prod:

In all cases you should get the privacy matters collection for the correctly locale depending on the url locale or your accept-language headers.

Note that if using a browser to test, 301s can be cached so clearing the cache between tests is a good idea.

muffinresearch commented 6 years ago

We pushed a redir into prod so this should be fixed now and when the link updates it should save the 301.

ValentinaPC commented 6 years ago

The link https://addons.mozilla.org/firefox/collections/mozilla/privacy/ is broken

Seems like the link is working now. Is there anything else we should be checking here?

I've also made a collection private, and logged out from AMO, and I can still see collection listing page. (i.e. Bookmarks collection). Is this ok?

willdurand commented 6 years ago

Seems like the link is working now. Is there anything else we should be checking here?

I think it is all good then.

ValentinaPC commented 6 years ago

Marking this verified fixed. Private collection issue is tracked separately.

mozilla / addons