search

mozilla / addons

☂ Umbrella repository for Mozilla Addons ✨
Other
123 stars 53 forks source link

Add a confirmation when adding add-ons to a collection #11749

Closed pwalm closed 6 years ago

pwalm commented 6 years ago

We need to add a confirmation when a user adds something to their collection, so they know it happened even if they don't see it. Similar to how I've mocked it up below (for ratings):

screen shot 2018-05-10 at 4 10 32 pm

Rules:

bobsilverberg commented 6 years ago

It should fade away after 5 seconds.

I'm not sure that we're doing this anywhere else. I guess we could enhance the Notice component to make that an option. @muffinresearch or @willdurand do you know if this is something we've done previously in the app?

willdurand commented 6 years ago

I don't think we have done that yet.

bobsilverberg commented 6 years ago

It should read: "Extension added" or "Theme added" depending on type.

@pwalm How important do you think it is to mention the specific type, as opposed to just saying "Add-on added"? I ask because we do not have access to the type in the current code, and we'd have to fetch the add-on via the API in order to know what type it is, just to display a more specific message.

pwalm commented 6 years ago

@bobsilverberg Not a deal breaker if we don't say the specific add-on type. Just say "Added to collection" instead.

bobsilverberg commented 6 years ago

Not a deal breaker if we don't say the specific add-on type. Just say "Added to collection" instead.

Great, thanks @pwalm. I've changed it to use that text.

ioanarusiczki commented 6 years ago

Verified fixed this on AMO dev with FF60(Win10 and Android 8.0) - the Added to Collection message is displayed when an extension or theme is added to the collection. The following works as expected:

The message bar should appear above the "Find add-ons" field. It should have the green checkmark glyph. It should read: "Extension added" or "Theme added" depending on type. - it's Added to collection instead

I noticed that the message won't fade away after 5 seconds - after adding the first extension/theme to the collection it remains permanent - I filed https://github.com/mozilla/addons/issues/11813

bobsilverberg commented 6 years ago

I see that @willdurand already pointed out that mozilla/addons#11813 is a duplicate of mozilla/addons-frontend#5101. Thanks @willdurand!