TypeError: filters.sort.split is not a function

willdurand commented 5 years ago

https://sentry.prod.mozaws.net/operations/addons-frontend-amo-prod/issues/5946007/

TypeError: filters.sort.split is not a function
  File "/srv/code/src/amo/components/SearchFilters/index.js", line 173, in SearchFiltersBase.split [as render]
    .split(',')
  File "/srv/code/src/core/components/ServerHtml/index.js", line 206, in ServerHtml.renderToString [as render]
    const content = component ? ReactDOM.renderToString(component) : '';
  File "/srv/code/src/core/server/base.js", line 116, in renderToString
    return ReactDOM.renderToString(
  File "/srv/code/src/core/server/base.js", line 410, in renderHTML
    renderHTML({ props, pageProps, store });
  File "/srv/code/src/core/server/base.js", line 152, in asyncGeneratorStep
    .status(componentDeclaredStatus)
...
(120 additional frame(s) were not displayed)

TypeError: filters.sort.split is not a function

/cc @bobsilverberg

For QA: This can be reproduced by specifying two sort URL parameters for the search page, e.g., https://addons.mozilla.org/en-US/firefox/search/?sort=hotness&sort=users.

bobsilverberg commented 5 years ago

Thanks @willdurand, I'll take a look.

AlexandraMoga commented 5 years ago

Verified fixed on -dev. The following links are no longer throwing 500 errors. Search results will take in account only the first sort parameter.

mozilla / addons

TypeError: filters.sort.split is not a function #13252