mozilla / addons

☂ Umbrella repository for Mozilla Addons ✨
Other
127 stars 41 forks source link

🏆 Recommended (trophy) badges obscuring 💲 (dollar) badges? – Some features may require payment #13647

Closed grahamperrin closed 4 years ago

grahamperrin commented 4 years ago

Example A

https://addons.mozilla.org/addon/xposer/

– I see the hint re: payment so rarely I forgot that existed, but when it's visible, it is both eye-catching and effective:

Xposer dollar

Example B

https://addons.mozilla.org/addon/video-downloadhelper/

Video DownloadHelper, no dollar

Video DownloadHelper, about, commercial

… about

commercial

Example C

https://addons.mozilla.org/addon/lastpass-password-manager/

LastPass: Free Password Manager, no dollar

LastPass: Free Password Manager, about, premium

… about

premium

image

Example D

https://addons.mozilla.org/addon/roboform/

RoboForm, no dollar

RoboForm, about

… about

(click away from AMO) ![RoboForm home, buy now, start business trial](https://user-images.githubusercontent.com/192271/70385491-fa5d8880-1985-11ea-94ea-ba76ef7a702a.png) ![RoboForm support, buy now](https://user-images.githubusercontent.com/192271/70385492-faf61f00-1985-11ea-9a82-2af266d0ed05.png)
willdurand commented 4 years ago

@grahamperrin that's because the requires_payment flag is set to false, I guess. Here is an example:

$ curl -s https://addons.mozilla.org/api/v4/addons/addon/video-downloadhelper/ | jq '.requires_payment'
false

Xposer returns true, hence the presence of the badge:

$ curl -s https://addons.mozilla.org/api/v4/addons/addon/xposer/ | jq '.requires_payment'
true

It's up to the developers to define this property in DevHub:

Screen Shot 2019-12-09 at 11 44 47
grahamperrin commented 4 years ago

Interesting, thanks.

Found, through trawling https://addons.mozilla.org/firefox/search/?page_size=100&recommended=true&sort=created&type=extension, just one of ninety-six Mozilla-recommended extensions that bears the dollar badge:

image

(full page) ![2019-12-09 11:26](https://user-images.githubusercontent.com/192271/70432354-fcebdb00-1a76-11ea-8283-202fa0b00075.png)

Please, might we have a brief chat in #addons or #addon-reviewers? Riot app running now. (I'd like to draw attention to something else, but not from GitHub.)

grahamperrin commented 4 years ago

Closing, re: William's https://github.com/mozilla/addons/issues/13647 since I found an example of AMO working as expected 👍


Re: one or more of the developers who either overlook or misinterpret this:

Screenshot of the 'Requires payment?' question

Requires Payment?

This add-on doesn't require any additional payments, paid services or software, or additional hardware.

– I'll follow up in IRC.

grahamperrin commented 4 years ago

Note to self, another: https://addons.mozilla.org/en-GB/firefox/addon/languagetool/

… We offer a Premium version which is linked from several places in the add-on. This add-on also works without payment and registration, though. …