search

mozilla / addons

☂ Umbrella repository for Mozilla Addons ✨
Other
127 stars 41 forks source link

Replace log in button with plain link #14000

Closed jvillalobos closed 3 years ago

jvillalobos commented 3 years ago

A really large number of users visit AMO and log in (which creates an AMO account if you don't have one) but don't appear to use the account in any way. It's possible that people think they need to log in, and the button's prominence encourages them to do so.

Let's change the button on the top right corner of AMO pages to a link. The position and copy should stay the same: Register or Log In.

The log in button used for reviews and collections should continue to be the same, as well as the button on Developer Hub.

championshuttler commented 3 years ago

@siddhi523 you might find this a good bug to start with :), good luck

siddhi523 commented 3 years ago

thanks, can you assign it to me @jvillalobos ?

caitmuenster commented 3 years ago

Hey @siddhi523, once you open a PR, we'll assign you to the issue. :)

caitmuenster commented 3 years ago

Hey @siddhi523, are you still interested in this? It turns out we have a deadline on this bug and need to start moving on it in the next week. If you're not able to do it, no worries at all -- there are other good first bugs without deadlines.

bobsilverberg commented 3 years ago

From a discussion with @verdi:

willdurand commented 3 years ago

Do not include an underline for the "Register or log in" link

we still need an underline for the hover/active styles, right? (for accessibility/keyboard navigation)

jvillalobos commented 3 years ago

The EW and DevHub links have no underline nor distinct hover styles, so this one should be consistent with those IMO.

ioanarusiczki commented 3 years ago

@bobsilverberg This is verified on AMO dev -FF87(Win10). on FF FF

non-FF browsers

nonFF