mozilla / addons

☂ Umbrella repository for Mozilla Addons ✨
Other
127 stars 41 forks source link

Exclude non en-US users from download funnel experiment #14225

Closed bobsilverberg closed 3 years ago

bobsilverberg commented 3 years ago

As discussed at https://github.com/mozilla/bedrock/issues/10207#issuecomment-861355640, we need to limit the download funnel experiment to only en-US users, as anyone with a different language should not be directed to the new experimental download page.

We might be able to hack this into the current experiment code, but it might be better to add a feature to the framework that allows us to exclude users from an experiment based on language. This is something that has been discussed in https://github.com/mozilla/addons/issues/14193 and that we will want to have in place at some point, so now seems as good a time as any to do it.

I will open a separate issue specifically about allowing for configuring an experiment based on language.

ioanarusiczki commented 3 years ago

@bobsilverberg I verified this on AMO dev - with several languages:

Important is what's the locale used into the URL when AMO is loaded the first time in the browsers:

Verified on AMO dev - Chrome, Edge.