[Task]: use new jobs/.../decision api to make decisions on job

eviljeff commented 6 months ago

Description

resolves https://mozilla-hub.atlassian.net/browse/AMO2-723

Previously if AMO wanted to resolve a cinder job with a decision via it’s api the only option was to create a decision on the entity, and then close the job. Now there is a new create decision on job api endpoint which will allow us to do it in a single step, and associate the decision with the job correctly.

Acceptance Criteria

### Acceptance Criteria
- [x] jobs/xx/decision is used for decisions on jobs
- [x] use of close job is removed

Checks

[x] If the issue is ready to work on, I have removed the "needs:info" label.

┆Issue is synchronized with this Jira Task

eviljeff commented 6 months ago

To test this issue:

take an action in the reviewer tools that resolves a job - e.g. a job that contains abuse reports, or an appeal
look in cinder in the AMO dev addon infringement queue, and the "Jobs" tab for that queue.
see the decision made in the reviewer tools there, resolving the job in cinder
The decision should also be in the "Decisions" tab as resolved (as opposed to status "Cancelled" like the older jobs)

ioanarusiczki commented 5 months ago

I see the status "Closed" instead of "Cancelled" and in Decisions tab the AMO reject action, I'll continue this tomorrow , try a couple more scenarios.

ioanarusiczki commented 5 months ago

I've added a comment into https://github.com/mozilla/addons/issues/14788#issuecomment-2115208071 so I can follow the unresolved issues there and mark this verified.

mozilla / addons