mozilla / addons

☂ Umbrella repository for Mozilla Addons ✨
Other
124 stars 53 forks source link

[Bug]: Send the correct email to reporters for "Developer feedback" and "Not enough information" #14785

Closed ioanarusiczki closed 2 weeks ago

ioanarusiczki commented 2 weeks ago

Followup https://github.com/mozilla/addons/issues/1787

What happened?

  1. Send one or multiple reports for an entity
  2. From Cinder go to a specific queue depending on what's been reported and assign job for the report
  3. Choose from Ignore action Developer feedback or Not enough information

What did you expect to happen?

This email should be sent to the reporter.

Is there an existing issue for this?

┆Issue is synchronized with this Jira Task

eviljeff commented 2 weeks ago

It seems this is almost certainly not a code problem, but that the policies neededed resyncing. I've done that on addons-dev. Can you retest @ioanarusiczki ?

ioanarusiczki commented 2 weeks ago

For "Developer feedback" the email below is sent -> it's for collections, ratings or users too

developer feedback

For "Not enough information" , same as above , this email is sent for all entities:

not enough information

Maybe it's been left out on purpose -> in both cases the second paragraph ends without "at this time" , it's "The Rating will therefore not be subject to any moderation action."

ioanarusiczki commented 2 weeks ago

@eviljeff This is only on -dev indeed, on -stage it's still incorrect for now.

eviljeff commented 2 weeks ago

@eviljeff This is only on -dev indeed, on -stage it's still incorrect for now.

sync'd on stage now too. (Policies in cinder prod are still in progress, so no sync there yet)

eviljeff commented 2 weeks ago

@wagnerand to press the sync button in django admin on prod when things are ready

ioanarusiczki commented 2 weeks ago

Working now on stage too, 👍 I should also keep in mind there's a sync for policies.